Comments (11)
Hello @RGBNu,
Can you reproduce this with the demo project ?
I'll check this asap.
Thanks
from facebookimagepicker.
Hello - I put a project to reproduce this issue at www.kx1.us/FBTest.zip
Since it is the most basic possible implementation of the FacebookImagePicker, I assume it must be something with our Facebook Developer account. (This test project uses an Info.plist from the other project.) But without any error feedback, I can't figure what it is.
Another update, it looks like the login screen does appear, just not the albums.
Thanks for the quick reply!
from facebookimagepicker.
Hello @RGBNu,
I just tried with your demo project with my facebook account and all the albums are showing up !
Maybe this is an issue with your album's types which are not handle by the picker ?
from facebookimagepicker.
Dang, that is very surprising. All my albums are pretty normal I think.. I've uploaded pics from desktop and my iOS device, that's about it.
One other thing to note is both myself and another tester were seeing this behavior. One thing we have in common is that we are both admins on our Facebook app. I wonder if that could be part of it? Just looking for any commonality.
from facebookimagepicker.
I'm also admin of the facebook demo app (which are in this repo) and I don't have any problem for showing my album. So I don't think it's your problem.
Keep me informed if you find the problem. I leave this issue open in case other people have the same issue :)
from facebookimagepicker.
Hello @RGBNu , did you find the solution of your problem?
from facebookimagepicker.
Greetings Florian -
After digging into your code and setting a million breakpoints, I figured out what's going on. In the class FacebookController, there is a segment of code beginning on line 81 which attempts to retry the next page by calling fetchFacebookAlbums again (line 87). However, the completion is not being passed back into the function call, resulting in the completion being nil on line 91, therefore render is never called in FacebookAlbumController, line 91. The fix was simple, just pass the completion back into the subsequent calls in FacebookController line 87.
Hope that helps!
from facebookimagepicker.
Many thanks ! :-)
Sorry for this bug, I didn't test to fetch a lot of album since the first version...
I'll fix it and make a new release.
from facebookimagepicker.
The v3.0.1 is now available with this fix, thanks !
from facebookimagepicker.
Greetings Florian --
I think we missed a slight detail on this issue. The request for albums now works with pagination, but the request for images within those albums still fails in the same way (endless spinner, no completion passed back in.) I tried to do a Pull Request, but I forget how to do it, ha. Anyway, in the file FacebookController.swift, change line 174 to selfStrong.fbAlbumsPictureRequest(after: after, album: album, completion: completion) Cheers!
from facebookimagepicker.
Hello @RGBNu, you can try this version : https://github.com/floriangbh/FacebookImagePicker/releases/tag/3.0.2 :-)
Cheers !
from facebookimagepicker.
Related Issues (20)
- Use Decodable to manage Graph API JSON
- Integrate without pod config HOT 1
- Question: SelectedBorderWidth & SelectedBorderColor HOT 2
- No Such Module Import Question
- Swift/Objective-C Facebook asks for login twice, won't display photos HOT 4
- No such module 'GBHFacebookImagePicker' HOT 4
- GalleryControlles does not conform HOT 2
- Select all HOT 2
- Convertion of GBHFacebook image HOT 1
- GBHFacebookImagePickerDelegate protocol implementation problem HOT 2
- Load images part of a facebook page
- Clean
- Please make compatible to FBSDKLoginKit 4.37.0 & FBSDKCoreKit 4.37.0 HOT 1
- Bump version HOT 2
- Problem with iOS 13 HOT 5
- Profile picture not loading on first click HOT 6
- Type 'SelectPhotosViewController' does not conform to protocol 'FacebookImagePickerDelegate' HOT 9
- pod update doesn't update to Facebook 5.5.0 HOT 1
- Expose the GBHFacebookNavigationController HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facebookimagepicker.