prevent upscaling about kirby-focus HOT 6 CLOSED

Thanks for your feedback. This should be possible and I'll check it out.

But what do you think should happen, if only one dimension (width or height) is larger than the original?

// original 800px x 800px

->focusCrop(1200,600)

Possible results

1. Crop only the height: 800px x 600px
2. Crop to desired reatio: 800px x 400px
3. Don't crop at all: 800px x 800px

from kirby-focus.

I would prefer to crop to the desired ratio (2).

And thanks alot for your effort and fast response.

from kirby-focus.

Crop means crop, not CropAndScale. For this reason I would select 1 :)

from kirby-focus.

I also prefer 1, but I will check how the Kirby crop() method handles this.

from kirby-focus.

Alright, Kirby crop() makes an upscale to match the larger value and then crops the image to the final dimensions. As far as I can see, there's no possibility to prevent this upscale.

Exactly the same like focusCrop() works at the moment.

from kirby-focus.

I came back this issue after quite a long time and I think I will stick to the current behavior, because it's the same way the Kirby crop() method works. Let's keep things consistent 😉

from kirby-focus.