Images being stretched about kirby-focus HOT 6 CLOSED

Ok, I managed to find out what's wrong with the output images. The image height is correct, it's 650px in the example, but the actual stretched height is equal to the width: 1440px. I stretched the original image in Photoshop and the circle is exactly the same.

So it seems like the script always does the "square" cropping but seems to output the correct image size. Maybe it's this line: https://github.com/flokosiol/kirby-focus/blob/master/focus.php#L29

from kirby-focus.

I downloaded a pure Kirby 2.3 Starterkit, installed the focus plugin and tested it locally and on my server. Same thing:

from kirby-focus.

I will have a look at this, thanks for reporting.
Did you implement the focusCrop method with one argument like this

<?php echo $image->focusCrop(200); ?>

or with two arguments like this

<?php echo $image->focusCrop(300,200); ?>

I guess I have to test some more edge cases (thumb height and/or width bigger than original, …)

from kirby-focus.

I tried both. If I crop a 200x200 square by <?php echo $image->focusCrop(200); ?> there's still stretching.

Can you please test the images I uploaded in the first post in your installation? Maybe it's something else. It stretches almost every image in my installations, with almost every crop ratio. If the image doesn't contain a circle or text it's not immediately noticeable, though.

from kirby-focus.

I think I found the problem, but I will do some more testing. If you can't wait for so long, you could you change this line …
https://github.com/flokosiol/kirby-focus/blob/master/focus.php#L132

$img->crop($x1, $y1, $x2, $y2)->resize($thumb->options['width'], $thumb->options['height']);

… to this …

$img->crop($x1, $y1, $x2, $y2)->thumbnail($thumb->options['width'], $thumb->options['height']);

Regards,
Flo.

from kirby-focus.

Wow, thank you for the fast solution! ❤️

from kirby-focus.