Comments (6)
Ok, I managed to find out what's wrong with the output images. The image height is correct, it's 650px in the example, but the actual stretched height is equal to the width: 1440px. I stretched the original image in Photoshop and the circle is exactly the same.
So it seems like the script always does the "square" cropping but seems to output the correct image size. Maybe it's this line: https://github.com/flokosiol/kirby-focus/blob/master/focus.php#L29
from kirby-focus.
I downloaded a pure Kirby 2.3 Starterkit, installed the focus plugin and tested it locally and on my server. Same thing:
from kirby-focus.
I will have a look at this, thanks for reporting.
Did you implement the focusCrop
method with one argument like this
<?php echo $image->focusCrop(200); ?>
or with two arguments like this
<?php echo $image->focusCrop(300,200); ?>
I guess I have to test some more edge cases (thumb height and/or width bigger than original, …)
from kirby-focus.
I tried both. If I crop a 200x200 square by <?php echo $image->focusCrop(200); ?>
there's still stretching.
Can you please test the images I uploaded in the first post in your installation? Maybe it's something else. It stretches almost every image in my installations, with almost every crop ratio. If the image doesn't contain a circle or text it's not immediately noticeable, though.
from kirby-focus.
I think I found the problem, but I will do some more testing. If you can't wait for so long, you could you change this line …
https://github.com/flokosiol/kirby-focus/blob/master/focus.php#L132
$img->crop($x1, $y1, $x2, $y2)->resize($thumb->options['width'], $thumb->options['height']);
… to this …
$img->crop($x1, $y1, $x2, $y2)->thumbnail($thumb->options['width'], $thumb->options['height']);
Regards,
Flo.
from kirby-focus.
Wow, thank you for the fast solution!
from kirby-focus.
Related Issues (20)
- Images not cropped on PHP 7.3 or 7.4 HOT 11
- Bug: Breaks when media-Folder is at another place HOT 4
- Question regarding 'components.thumb' HOT 2
- kirby3-colorist supports 'Focus' HOT 4
- Does not create cropped images on server HOT 5
- Update focus field on `file.replace` HOT 4
- Transparent PNG Problem HOT 1
- Does not play nice with `translate: false` HOT 1
- WebP Support HOT 12
- [Question] Is the support for Kirby Block previews planned HOT 1
- focusSrcset does not update URL on focus point changes HOT 11
- New Kirby 3.6 Feature to support multiple mime-types is not working with this plugin for GD. HOT 3
- WebP and AVIF generated images put into wrong folder in v3.0.8 HOT 26
- Kirby 3.5.x not supported in v3.0.8 HOT 7
- [Question] multiple focus fields HOT 2
- CSS not being loaded HOT 2
- Reset focuspoint HOT 1
- Optional color fading ? HOT 2
- Preview missing for svg HOT 2
- value without effect for foxi HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kirby-focus.