Git Product home page Git Product logo

Comments (2)

flokosiol avatar flokosiol commented on July 3, 2024

Thanks for reporting. As you mention correctly, focusCrop() doesn't add -qX to the filename. This means that Kirby doesn't recreate the thumb, if the quality changes.

Flushing your thumbs folder should force Kirby to recreate the images.

I'm already working on this issue, because there will be a possibility to use more parameters than quality in the future. As you can see in the develop branch I tried to use a hash which respects all possible parameters, but this leads to unreadable filenames … I'm not sure, if this is the best solution.

As a quick fix you could change line 55 of methods/file.php to this …

if ($quality) {
  $params['quality'] = $quality;
  $params['filename'] = '{safeName}-' . $params['width'] . 'x' . $params['height'] . '-' . $params['focusX']*100 . '-' . $params['focusY']*100 . '-q' . $params['quality'] . '.{extension}';
}

from kirby-focus.

mirkoclemente avatar mirkoclemente commented on July 3, 2024

Thank you for the clarification and the little fix. I'm looking forward to the new features.

from kirby-focus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.