Translations with newlines are moved and replaced with empty string about bartycrouch HOT 6 CLOSED

Thanks for this issue. Will have a look next week, when I have more time. Sorry for keeping you await.

from bartycrouch.

I'm seeing something similar, it removes the translation completely for components with multiple lines of text. If I remove the newline it works as expected.

On the other hand, I pulled down the latest BartyCrouch so I could write a test for this and it handles the newline case as expected, even for the file that I am having issues with.

I'm running BartyCrouch 3.9.0 through homebrew and using Xcode 9.0. Any ideas would be appreciated.

from bartycrouch.

I've now found the time to have a deeper look into this.

By default BartyCrouch adds translations with empty values to the end of your strings file. If you want to keep the base translation as the value in your languages, you need to specify the --default-to-base command (or the -b shorthand) – this will add new translations with their Storyboard content as value.

Other than that, in my tests all multiline translations (those including newlines) were handled correctly. Also reordering should only happen if you specify the --sort-by-keys or -s option to the code subcommand. If it really happens to the interfaces command as well, it would be very helpful if you could add a test to the project and send a PR with it so we can fix the test in order to fix the issue.

from bartycrouch.

Still looking into this, seems to be fine in the tests, but once I compile the bartycrouch binary and try to run it via command line it simply ignores strings that have newlines.

from bartycrouch.

After looking into the regex, it seems like currently newlines are supported in the /* comment */ part of the string but not in the actual key-value pair line. I've opened a PR with a slightly modified regex that will pick up values with new lines.

If you're dying for this change (like me) you could pull my fork and build it yourself until it gets merged.

from bartycrouch.

Hopefully fixed via #75.

from bartycrouch.