Option to Exclude path to avoid picking up localisation from Pods and imported libs about bartycrouch HOT 8 CLOSED

What about we simply add Pods/ to this array? That should solve your problem easily, shouldn't it? Wanna post a PR? Should be a quick one. ;)

from bartycrouch.

Yes, of course Pods/ should be added there.

Still, there may be cases when you integrate some library by copying sources or using git submodule and it appears in project root among your regular sources.

from bartycrouch.

Sure, there could be such cases. If you want, you can add options named exclude and include for such cases which are whitelists or blacklists of folders. But I think using a folder named Sources (or ProjectName which is Xcodes default) is an existing workaround which is also a good idea in general (e.g. the Swift Package Manager recommends this as well).

Unfortunately I don't have much free time right now to fix issues that are no real problems. You had a real problem with the Pods folder which many others might have, too. So I suggested a solution for that. For any other ideas I'm thankful for your issue but I won't have time to deal with it anytime soon. I'd happily merge it though if it was implemented, tested and documented in a PR though. ;)

from bartycrouch.

No problem. Should I add Pods/ there or you will do it?

from bartycrouch.

A PR would be nice! 🙂

from bartycrouch.

The fix from dd5d07e doesn't address the OP's request to avoid pulling in 3rd party (cocoapod) strings. The array to which Pods/ was added filters the -l /directory/containing/all/Localizables path rather than the -p /path/to/code/directory path.

I've implemented a similar directory filter in CodeCommander.findFiles which does the trick in our project. Would you prefer to reopen this issue or start a new one?

from bartycrouch.

Please open a new issue and feel free to post your change as a PR, independent from which issue it fixes. Would be great 👍

from bartycrouch.

The discussion appears to continue at #156

from bartycrouch.