Git Product home page Git Product logo

Comments (3)

resuna avatar resuna commented on June 22, 2024

I was going to say "of course the only code that refers to MAP_NOCORE was
inside an #ifdef guard for MAP_NOCORE".

But I thought "let me check on that" and lo and behold, looks like there's
been a bit of a regression.

I'm having firewall issues getting in to github from here, so I'll have to
check it in when I get home, in the meantime here's a patch.

diff --git a/ctables/shared/shared.c b/ctables/shared/shared.c
index 77d0d9f..0dbbab9 100644
--- a/ctables/shared/shared.c
+++ b/ctables/shared/shared.c
@@ -119,13 +119,18 @@ void shared_perror(char *text) {

#ifdef MAP_NOSYNC
-# define DEFAULT_FLAGS (MAP_SHARED|MAP_NOSYNC|MAP_NOCORE)
+# ifdef MAP_NOCORE
+# define DEFAULT_FLAGS (MAP_SHARED|MAP_NOSYNC|MAP_NOCORE)
+# else
+# define DEFAULT_FLAGS (MAP_SHARED|MAP_NOSYNC)
+# endif

define WITH_FLAGS 1

#else
-# define DEFAULT_FLAGS (MAP_SHARED|MAP_NOCORE)

ifdef MAP_NOCORE

+# define DEFAULT_FLAGS (MAP_SHARED|MAP_NOCORE)

define WITH_FLAGS 1

else

+# define DEFAULT_FLAGS (MAP_SHARED)

define WITH_FLAGS 0

endif

#endif

from speedtables.

lehenbauer avatar lehenbauer commented on June 22, 2024

Hi LordPraslea, I've committed an update, 8f6a144, that should allow speedtables to compile on operating systems whose mmap doesn't support MAP_NOCORE.

Please give it a try.

from speedtables.

LordPraslea avatar LordPraslea commented on June 22, 2024

Hi, it compiled perfectly, and the example worked:)

Thanks for the very quick fix. And keep up the good work, speedtables seems very promising I'm amazed by the things it does just by going through the files and browsing the documentation and it looks like an answer for many problems.

from speedtables.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.