Git Product home page Git Product logo

Comments (7)

flesler avatar flesler commented on May 23, 2024

Will check this out asap.

from jquery.scrollto.

flesler avatar flesler commented on May 23, 2024

One question, are you using "vainilla" scrollTo or serialScroll/localScroll on top?
Considering you call the plugin each time you need to scroll, you can basically define what's the offset before each call by customizing the options object.
If you are using those plugins, you can change the value within the onBefore callback.
Wouldn't that be enough?

from jquery.scrollto.

ioleo avatar ioleo commented on May 23, 2024

@flesler dynamic offset would be very useful for responsive layouts, for example in twitter bootstrap Hero template, the fixed navbar has 47px. So I need to offset all my localscrolls by 47. But if the viewport is smaller than 980px then responsive bootstrap styles change navbars position from "fixed" to "static"... and then the offset is no longer needed.

In this case it would be great if we could do:

$('.navbar').localScroll({
    duration: 800,
    offset:   { 
        top: function(){ return ($('.navbar').css('position') == 'static') ? 0 : -47 }
    }
});

from jquery.scrollto.

ioleo avatar ioleo commented on May 23, 2024

For future reference:

  • following @flesler 's post this code did the trick:
$('.navbar').localScroll({
    duration: 800,
    onBefore: function(){
        this.offset = {
            top: ($('.navbar').css('position') == 'static') ? 0 : -47
        };
    }
});

from jquery.scrollto.

flesler avatar flesler commented on May 23, 2024

I think that's good enough. That's the reason I passed the settings to the
onBefore. What do you think.

On Tue, Mar 26, 2013 at 9:35 AM, loostro [email protected] wrote:

For future reference:

$('.navbar').localScroll({
duration: 800,
onBefore: function(){
this.offset = {
top: ($('.navbar').css('position') == 'static') ? 0 : -47
};
}});

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-15455413
.

Ariel Flesler

from jquery.scrollto.

ioleo avatar ioleo commented on May 23, 2024

@flesler i think onBefore is enough, you might just want to emphersize it in docs - it took me a long while to find out that onBefore is what I needed

from jquery.scrollto.

ioleo avatar ioleo commented on May 23, 2024

@flesler by the way, thank you for creating and shareing these great plugins 👍

from jquery.scrollto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.