Git Product home page Git Product logo

Comments (4)

mxfilerelatedcache avatar mxfilerelatedcache commented on September 2, 2024 1

Hey, thanks for your effort!

I just added FLATHUNTER_IS24_COOKIE as an environment variable and tested whether it works using the urls from the config.yaml, thus a combination of both config.yaml and environment variables. Everything now works as expected.

I close the issue now.

from flathunter.

pomeloy avatar pomeloy commented on September 2, 2024

From a quick glance, having the IS24-cookie or other crawler-specific settings read from an ENV variable is currently not possible without some code overhaul or refactoring.

Your configuration seems fine. Can you try changing the message format in the config.yaml to check whether the file gets read?

from flathunter.

mxfilerelatedcache avatar mxfilerelatedcache commented on September 2, 2024

Hey @pomeloy, I did some trial & error and the solution seems to be the following: Once you define the urls inside the config.yaml instead of the docker-compose.yaml, the script seems to look for the information in the config.yaml, and then also used the cookie from there.

As the issue technically still persists, I would leave it open for now. However, with my fix, it is solvable.

from flathunter.

codders avatar codders commented on September 2, 2024

I've added the option to override the IS24 cookie with an environment variable in #587 - you can now set FLATHUNTER_IS24_COOKIE. In general it should be fine to combine the config file with the environment variables. If the environment variables are present, they will override the settings in the file. And if no config file is present, everything should be read from the environment.

I've added some tests for this. If you find that the functionality isn't working as expected with the latest code on main, please let me know. If not, please close the ticket as resolved.

Thanks for the report!

from flathunter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.