Git Product home page Git Product logo

Comments (10)

tobyzerner avatar tobyzerner commented on June 9, 2024

I've noticed this at times too, but it's one of those ones that are difficult to reproduce consistently. We'll get to the bottom of it eventually though!

from issue-archive.

franzliedke avatar franzliedke commented on June 9, 2024

I often see a jump with the result of not seeing the first unread post when the discussion contains images (which seem to be loaded after jumping to the correct place in the discussion).

from issue-archive.

tobyzerner avatar tobyzerner commented on June 9, 2024

@franzliedke That is indeed another issue (but I don't think it's the cause of the problems in the screencap above). How would we fix that, though? Maybe we could set an onload handler to anchor the scroll position when we render the posts?

from issue-archive.

franzliedke avatar franzliedke commented on June 9, 2024

Yep, sounds like the only solution.

from issue-archive.

franzliedke avatar franzliedke commented on June 9, 2024

I just stumbled across this library, that should fix the image load scrolling behavior: https://github.com/changbenny/scrollbear

from issue-archive.

askvortsov1 avatar askvortsov1 commented on June 9, 2024

Possible duplicate of flarum/framework#285?

from issue-archive.

askvortsov1 avatar askvortsov1 commented on June 9, 2024

Fixed in flarum/framework#2160

from issue-archive.

askvortsov1 avatar askvortsov1 commented on June 9, 2024

Actually, I'll reopen this for now as afaik we haven't tested the effects of the new changes on posts with images that load after the posts have loaded.

from issue-archive.

matteocontrini avatar matteocontrini commented on June 9, 2024

This is related to #261 as well.

Also: since this issue was created, Chrome and Firefox introduced scroll anchoring, which should have reduced this issue a lot.

from issue-archive.

matteocontrini avatar matteocontrini commented on June 9, 2024

I'm posting here because I think this isn't actually related to images. I have a user reporting that this is still happening to him even in discussions where there are no recent images, and the behaviour he's seeing is exactly the one of the GIF in the first post (where I see no images, anyway). He clicks a discussion with unread posts and he's brought to 20-30 messages above the actual message he should be pointed to.

I'm running beta.15 with commits d59a5922609c012d3cba2148e498d78737ed4b07 and 30c4c139eb15c1f9bf809b58be5a2d4c918cc6ae cherry-picked, which have to do with the PostStream. The user is using Chrome on Android/desktop. I haven't personally seen this issue recently, but apparently it's still there even after recent improvements.

from issue-archive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.