Git Product home page Git Product logo

Comments (4)

kwsch avatar kwsch commented on August 28, 2024

Gen 4 stores two save files; I don't think having a const offset would work as intended. Gotta detect which save file is active based on the incremental Counters in the footer to get the actual offset! If you write to the wrong save file, you won't see the changes made in-game.

Also, be careful to not set a flag with a value higher than the bitflag array length. Eon Ticket (2048) is 0x800, which would overflow to the lowest bit of Card 1's ID. Wouldn't be a noticeable problem, but if users have a hacked card with an invalid ID it'd toggle a bit beyond the intended range :)

from pksm.

BernardoGiordano avatar BernardoGiordano commented on August 28, 2024

Good to know!! Thanks so much, you're really awesome

from pksm.

BernardoGiordano avatar BernardoGiordano commented on August 28, 2024

Made a few modifications basing upon PKHeX source. Does general block and storage block have to be calculated every time I do an operation, or only at save loading? I'm currently calculating it only at save loading and passing these values to every function that needs them, but still no modifications appear in game

from pksm.

BernardoGiordano avatar BernardoGiordano commented on August 28, 2024

immagine
EDIT: Modifications made on Pearl worked, PKHeX recognizes them. It did not work for HG, but since it worked on Pearl, and the algorhitm is the same, I presume it's only a corrupted save of mine. Will leave this open until more testes are done

from pksm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.