Comments (6)
jjlauer
commented on June 26, 2024
Hey Mark,
Sounds reasonable to me. Would you be interested in helping make that
modification and submitting a PR?
…-Joe
On Tue, Apr 4, 2017 at 2:18 PM, Mark Vieira ***@***.***> wrote:
When using the optimized option in the Rocker compiler the hot reloading
feature is disabled. Since the LAST_MODIFIED field in the compiled
templates is only used for this purpose it should be omitted when this
option is used. The use case here is that we want to cache these compiled
templates and reuse the outputs in conjunction with Gradle build cache
<https://docs.gradle.org/release-candidate/userguide/build_cache.html>.
Having different outputs for the same inputs breaks this capability.
Currently we are manually stripping these fields out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#55>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjwAsLdl8mRPBXttwvSSCj4YZWAGaD_ks5rsomRgaJpZM4MzPOQ>
.
from rocker.
jjlauer
commented on June 26, 2024
@mark-vieira Took a look at what you suggested and I have a couple questions. First, the field LAST_MODIFIED doesn't exist -- did you mean MODIFIED_AT ? Second, that value is the "last modified" value from the source file itself. I guess my question is -- do you see that value change on your system if you didn't actually the underlying source file?
from rocker.
mark-vieira
commented on June 26, 2024
First, the field LAST_MODIFIED doesn't exist -- did you mean MODIFIED_AT
Doh, yes :)
I guess my question is -- do you see that value change on your system if you didn't actually the underlying source file?
Not for local development, but this value changes when doing things like fresh checkouts. So two CI builds using the same source will have different compiled output.
from rocker.
mark-vieira
commented on June 26, 2024
I've gone ahead and submitted pull request #58 to address this.
from rocker.
jjlauer
commented on June 26, 2024
@mark-vieira Excellent work. Pushed out v0.18.0 to maven central with your changes.
from rocker.
etiennestuder
commented on June 26, 2024
Awesome to have this released so quickly!
from rocker.
Related Issues (20)
- Using template in RockerBody does not produce expected result HOT 1
- rocker-compiler.conf is in incorrect folder HOT 1
- Centralized conditional RockerContent rendering ? HOT 2
- Document required template extensions
- GraalVM compatibility HOT 4
- Warnings in Gradle Plugin (@Input annotation used on property of type 'File') HOT 6
- call java function in template HOT 1
- rocker-maven-plugin templateDirectory
- With block invalid: multiple equals symbols found for assignment String href = "/abc?x=y"
- [Doc] it's unclear how to instantiate Rocker
- Loading templates from classpath / jar ? HOT 1
- Parentheses right after variable HOT 2
- Compile time include postprocessor
- support Java 11 HOT 1
- Github latest release points to outdated release.
- Unable to get hot-reload working with tomcat server HOT 3
- Question about formatting
- Generation crashes with NPE if a non-normal file is present in the template directory HOT 1
- Global default null value rendering to avoid NPEs
- it's abandoned? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocker.