Enhance @with by supporting multiple arguments about rocker HOT 9 CLOSED

Hey @jjlauer

I had other things to do past month, but at last I had the time to deal with this. I just created a pull request to resolve this enhancement.

See the request for all the details, in short it uses the normal comma and no escapes are necessary.

Could you merge it in and release the version later on?

Thanks!

from rocker.

from rocker.

Ok, that felt like the better option to me as well. Going to pick this one up then. :)

from rocker.

Hey @jjlauer,

While working on some tests for the with block, I encountered the following:

@with(String s = s.get(0)) {
  @s
}
else {
  // it will never get here, but the else is allowed here
}

The above is currently allowed already, though the else will never be executed since this is not a null-safe block (it is a bit like dead code).
This may be a bug, and it may be nice to actually have it fail, so users do get an error about it.

I can fix this alongside this enhancement if you want, to allow the else only for a null-safe with block. I intend to forbid it already for the multiple arguments one anyway.

What has your preference?

from rocker.

from rocker.

Hey @jjlauer,

All right.

How do we want to escape the comma, as it can easily be used in the expressions e.g.

@with (List<String> subs = strings.sublist(1\,2), List<String> anotherSub=strings.subList(0\,1).subList(0\,1), String t = "hello\, world") {
}

In the above example I escaped the relevant ones with a single back slash, I guess that would be my preference. What do you think?

from rocker.

from rocker.

Semicolon would not really work either, since it can be used inside a String (see above).

I'll think about it for now on how to deal with it. If I get the comma working I prefer that over something else. If not then we can do something else.

from rocker.

Thanks for applying the pull request and releasing @jjlauer!

I will close this issue then. :)

from rocker.