Git Product home page Git Product logo

Comments (2)

jjlauer avatar jjlauer commented on July 4, 2024

I'll bounce back your issue by asking what you're looking to solve? If you explain a bit more what you're looking for then maybe there's a different solution.

Originally RockerModel was designed be the only public interface required, but as the project has evolved, DefaultRockerModel implements enough functionality that only models extending from it can be rendered.

from rocker.

ldaley avatar ldaley commented on July 4, 2024

I don't have any blocking problem.

What I hit was that I tried passing instances of RockerModel through to templates and rendering them inline. This didn't work, and then I went looking to see if it could work. I then noticed that it does work for DefaultRockerModel. This means that I need to declare the model objects being passed around as this type which then begs the question, what's the point of the interface?

It's not a blocking problem, but it's a confusing situation.

I wasn't sure what the intention was based on the code. If it is a requirement that everything extend DefaultRockerModel, then this type should arguably be promoted to a more β€œpublic” standing.

from rocker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.