Streams3 adaptor / transform (s) about bob HOT 6 CLOSED

Ok so I dunno why I didn't think about this before but pull-stream has modules that do this that I should be able to adapt. I am not sure they do it 100% correctly, but if it works it works.

e.g. https://github.com/pull-stream/pull-stream-to-stream, https://www.npmjs.com/package/pull-to-stream

Edit: thanks to @Raynos for this very obvious suggestion. 🤦‍♂

from bob.

OK I think it works. Like. Actually. WORKS.

https://github.com/Fishrock123/bob/blob/streams3-adaptor/helpers/bob-duplex.js

Test cases:
(manually verify the output file, readme_ or readme.gz (there is an ungzip helper in tests/).
(may require Node 13)

node tests/bob-streams3-from-source.js readme.md

node tests/bob-streams3-to-sink.js readme.md

node tests/bob-streams3-files.js readme.md

node tests/bob-streams3-zlib.js readme.md

Use NODE_DEBUG=bob to see what is happening.

Replace readme.md with your choice of file.

from bob.

Some semi-working progress here: https://github.com/Fishrock123/bob/tree/streams3-adaptor

Seems to work(?): fs-source -> duplex --pipe-> duplex -> fs-sink

Doesn't work: fs-source -> duplex --pipe-> zlib-gzip-transform --pipe-> duplex -> fs-sink

cc @mcollina

from bob.

from bob.

source -> (sink -> duplex) -> zlib -> (duplex -> source) -> sink

Wouldn't constructing that be really awkward?

Ideally I'd like:

Stream(sourceOrStream).pipe(streams3_transform).pipe(Stream(sinkOrStream))

from bob.

Ok next bit is to write reasonable automated tests, haha 😬 .

from bob.