Wrong logic in Controllers' requireManagerLogin method about webtrees HOT 3 CLOSED

There might have been some performances differences in the past, but now that the preferences are all retrieved once, there should not be much difference.

I think you are correct. The code would be much clearer if it simply used

!userGedcomAdmin(WT_USER_ID, $gedcom_id)

If you have time to update this.... ;-)

from webtrees.

Hello, and sorry I did not reply earlier, I was away for few days.

I can update it indeed, as it would bring a lot more clarity to the code.
The only point to keep in mind (as commented in #129) is that there is the case where the user is not explicitly an admin of the gedcom for which the method userGedcomAdmin needs to check whether it is a global administrator or not. To do so, it needs a call to the DB (as there is no cache for users' global preferences). In the current logic, the method is called only in the case where $ged_id!=WT_GED_ID, but if we simplify it, it would be called in all cases, so would bring a slight performance hit for users who are global admin without being the current gedcom admin.

Let me know your thoughts about it.

I can as well in parallel try to work on a improvement on users' global preferences, the same way you did for Gedcom/Tree, with maybe the introduction of a WT_User class.

Jonathan

from webtrees.

I have created an initial WT_User class.

I need to test this with various versions of PHP

from webtrees.