Git Product home page Git Product logo

Comments (2)

erig0 avatar erig0 commented on September 26, 2024 1

Overlapping entries is a minor issue that deserves a warning at most.

It's not that simple. firewalld supports multiple backends each with their own nuances and bugs around coalescing and breaking CIDR/range entries. Adding overlapping sets is usually okay. It becomes complicated when you start removing entries.

e.g.
add 10.10.10.0/24
add 10.10.0.0/16
add 10.0.0.0/8

then
remove 10.10.0.0/16

On the backend "10.10.10.0/24" would also be implicitly removed. That means firewalld has to also detect and handle this. But then "the config disappeared".

Maybe the user meant to "remove" everything in 10.10.0.0/16, EXCEPT those in 10.10.10.0/24. This is harder, firewalld would have to figure it out and only send the real removes to the backends. That gets complicated for multi dimensional sets.

In short, it's much less complicated to disallow overlapping sets.


It may be that the backends have better support for breaking and coalescing entries and this can be revisited. It's important to note that disallowing overlapping entries was done in response to bugs and reports.

from firewalld.

vgaetera avatar vgaetera commented on September 26, 2024

Thanks for the answer, I hope this can be implemented someday, otherwise it requires to find and eliminate possible overlapping entries from the list before trying to load it with Firewalld, which is not so trivial specifically when working with large IP sets utilizing GeoIP data.

from firewalld.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.