BUG: Greater error than expected in quadrilateral GLL elements about firedrake HOT 4 CLOSED

@pbrubeck do you have any ideas?

from firedrake.

The CG dofs are not in lexicographic ordering anymore, but we still generate quadrature rules in lexicographic ordering. In 1D we order first the vertex dofs and then the interior ones.

from firedrake.

There is definitely an inconsistency with the DOF and quadrature orderings, I'll assign this bug to myself.

from firedrake.

A temporary fix is to reorder the GLL quadrature rule to match the new order the GLL DOFs.

def gauss_lobatto_legendre_line_rule(degree):
    fiat_make_rule = FIAT.quadrature.GaussLobattoLegendreQuadratureLineRule
    fiat_rule = fiat_make_rule(FIAT.ufc_simplex(1), degree + 1)
    finat_ps = finat.point_set.GaussLobattoLegendrePointSet
    perm = [0, degree, *list(range(1, degree))]
    points = finat_ps(fiat_rule.get_points()[perm])
    weights = fiat_rule.get_weights()[perm]
    return finat.quadrature.QuadratureRule(points, weights)

We wanted to make this quadrature rule more user-friendly, by supporting strings as the scheme kwarg:
https://github.com/firedrakeproject/tsfc/pull/306/files

from firedrake.