Git Product home page Git Product logo

Comments (6)

connorjward avatar connorjward commented on September 4, 2024

In general the adjoint shouldn't play well with notebooks due to the possibilities for out-of-order execution. However for this case would it be sufficient to reset the tape in one of the uppermost cells? That would also be a convenient place to warn the user about the perils of running the cells in the wrong order.

from firedrake.

Ig-dolci avatar Ig-dolci commented on September 4, 2024

I tried

     get_working_tape().clear_tape()
     get_working_tape().reset_blocks()

That was not sufficient to fix this failure.

I agree with you about the warning.

from firedrake.

connorjward avatar connorjward commented on September 4, 2024

I think I found a solution. If you replace continue_annotating() at the top of the notebook with

if not annotate_tape():
    continue_annotation()

then it seems to work. I think this is because of the way annotation is tracked with an integer rather than a boolean so calling continue_annotation() twice actually breaks things.

from firedrake.

ReubenHill avatar ReubenHill commented on September 4, 2024

I think I found a solution. If you replace continue_annotating() at the top of the notebook with

if not annotate_tape():
    continue_annotation()

then it seems to work. I think this is because of the way annotation is tracked with an integer rather than a boolean so calling continue_annotation() twice actually breaks things.

That sounds like a bug, did you report it? I can't see anything here or here

from firedrake.

connorjward avatar connorjward commented on September 4, 2024

I think I found a solution. If you replace continue_annotating() at the top of the notebook with

if not annotate_tape():
    continue_annotation()

then it seems to work. I think this is because of the way annotation is tracked with an integer rather than a boolean so calling continue_annotation() twice actually breaks things.

That sounds like a bug, did you report it? I can't see anything here or here

See dolfin-adjoint/pyadjoint#111

from firedrake.

Ig-dolci avatar Ig-dolci commented on September 4, 2024

This issue is sorted with pyadjoint PR 113

from firedrake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.