Git Product home page Git Product logo

Comments (5)

jwngr avatar jwngr commented on July 30, 2024

Thanks for reporting this to us. It does in fact look like a bug. I think your proposed solution is correct. We actually already have that check for undefined logic here, but just don't have it here. I'll put together a fix, try to get a test for it, and deploy a new version of the lib.

from geofire-js.

ZenPylon avatar ZenPylon commented on July 30, 2024

Just a note - my possible solution is to just break from the loop rather than continue through the loop and check each key. My reasoning was that if the query is cancelled, none of the key_entered callbacks should be fired anyway. Not sure if that's accurate, but I'm using that for now!

Cheers.

from geofire-js.

jwngr avatar jwngr commented on July 30, 2024

Both approaches should work. I put together the initial suggestion which works well enough :)

from geofire-js.

jwngr avatar jwngr commented on July 30, 2024

Version 3.2.4 of GeoFire JS is out. Should fix your problem. Let me know if you are still running into issues!

from geofire-js.

ZenPylon avatar ZenPylon commented on July 30, 2024

Awesome, thanks!

from geofire-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.