Comments (5)
@bolshchikov - Thanks a lot for the suggestions! I'll take a look at each one this week and do some perf testing to see how much they help.
from geofire-js.
@bolshchikov - Thanks again for the perf suggestions. I implemented numbers 1 and 2 and they are currently awaiting code review in pull request #52. I did not implement suggestion 3 since those two operations are not the same. If you just set it to undefined
, then hasOwnProperty()
will return true
. But when we delete
, hasOwnProperty()
returns false
. I don't think adding a bunch of checks to fix this discrepancy is worth the potential speed improvement. Although I do think there would be some speed improvement, so thanks for alerting me of that.
At this point, I think most of the perf gains we will get in GeoFire will come from improvements to the underlying Firebase library itself. We will continue to make that faster so that the libraries that build on top of it are even faster!
I'll keep this task open until we ship a version with these changes in them. Which should happen in a day or so.
from geofire-js.
@jwngr, great improvements, but the regarding the second, I've suggested to use lodash library for perf method optimization since it's the target of the library. Iterating over Object.keys is more effective however native .forEach
is way slower than a for loop iteration.
So ideally the code would look like the following
var i = 0, arr = Object.keys(foo), len = arr.length;
for (i; i < len; i ++) { /* access the property: foo[arr[i]] */ }
So here, we defined variables outside of the loop to prevent from recalculation and using the regular for loop. This performance will be the best.
Regarding the delete
vs undefined
, there are many talk about it (see this thread). In short, V8 optimizes JS code, and call of delete causes the change of the object which leads to deoptimization, which in turn leads to degradation up to 12x.
I can go over the code and make a PR if you like.
from geofire-js.
I've updated the pull request again. We are not going to include the lodash library itself because the perf benefits it brings are outweighed by the fact that we now have an extra dependency and increased file size. I definitely like the idea of using the tricks it uses to speed up the code though. Thanks for sharing.
from geofire-js.
These improvements were released in version 3.0.3. Thanks again!
from geofire-js.
Related Issues (20)
- Can't instantiate Geofire ref in TS HOT 6
- Can't instantiate GeoFire in TS
- Query base on GeoJsonLayer polygon HOT 3
- Query does not return locations inside of greater locations HOT 1
- MarkerOptions.anchor doesn't affect on position HOT 1
- when run geofire got erroe( s._firebaseRef.orderByChild is not a function) HOT 1
- Potential Security Issue HOT 2
- Large radius query returns different results for small amounts either side of the meridian HOT 1
- how to use geofire in firebase admin sdk instead of firebase javascript sdk HOT 2
- Firebase version 9 HOT 17
- What to do when my project using Firebase version 9 but i need to use geofire HOT 1
- Geofire
- How to get a query response without any event on GeoFire?
- MIT License file missing HOT 1
- Missing `once` or `get` and determination when search finished HOT 4
- Bug in the geoFire library HOT 2
- 't.split' error and 'Unknown node type' at firebase HOT 3
- Geofire querying data totally out of range for radius zero
- Bug: Setting Geofire Key (childPathObj.split is not a function)
- Maximum call stack size exceeded error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geofire-js.