Git Product home page Git Product logo

Comments (4)

bertrik avatar bertrik commented on June 22, 2024

Please fix this, either doing complicated stuff like write-read-compare (as suggested here), or just return true (like in my pull request). The best compromise may be to simply return the i2c result, as a bool (success or not). I'm a bit surprised actually that something like this is classified by Arduino as a compile warning, I would consider this a hard error because currently the result is completely undefined.

from bme280.

finitespace avatar finitespace commented on June 22, 2024

Thank you for bring this to my attention @coelner. I have been extremely busy recently and haven't had time to look into this. My apologies. I will try to look at this tonight.

@bertrik the proper value needs to be returned or the function needs to be changed to void. I will take a look and see which is appropriate in this situation.

Regards,
@finitespace

from bme280.

finitespace avatar finitespace commented on June 22, 2024

#117 is a duplicate, which I realized later, I have a new branch 117-non-void-return (or something like that)

@coelner @bertrik @atar-axis could one of you (or anyone else) test this branch, I don't have hardware right now, on biz trip. If it works as intended, then I will release 3.0.0. Finally! I need to pay attention to you guys more often. :)

from bme280.

finitespace avatar finitespace commented on June 22, 2024

#121

from bme280.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.