Git Product home page Git Product logo

Comments (6)

mclueppers avatar mclueppers commented on July 21, 2024

It looks like you did some patches. Why not forking the project and creating PR later on? Way easier than just suggesting someone else to program it for you ;)

from bme280.

finitespace avatar finitespace commented on July 21, 2024

The constructor does not call initialize, begin does. For now, you can call begin to re-initialize the sensor. I will think about if another function is required to provide different word choice when re-initializing.

Tyler

from bme280.

pabloandresm avatar pabloandresm commented on July 21, 2024

I am currently developing the fix for this as you requested.
I don't think it is a good idea to close the bug just like that. It is a real bug. The specification says that if selected "forced mode", the after the temperature reading the forced mode is unsetted and you need to set it again. In this implementation the forced mode is setted only the begin() so it cannot be setted again.
Worse case you should leave it open, as it is a real bug.
I'll tell you when I finish the fix.
Pablo

from bme280.

finitespace avatar finitespace commented on July 21, 2024

Pablo,

I don't believe this is an issue. First off, the config reg does not contain the mode settings. These are held in the measure ctrl reg which can be reset at anytime by calling setMode. Second, I believe if no mode is specified it defaults to forced. Third, looking at the diagrams it says it returns to sleep after executing a forced read, but as previously stated I believe it defaults to forced on the next read. Finally, I don't believe the registers are modified, so any config settings will be preserved. All this in mind, while the datasheet shows that it returns to sleep mode, and it might be interpreted that the config needs to be updated every read, I do no see any evidence that this is necessary in practice.

Tyler

from bme280.

finitespace avatar finitespace commented on July 21, 2024

Pablo,

I did a massive refactor of the code this weekend and I actually found that is not an issue because it is already being done. The config is pushed to the bme before every read if in forced mode.

Tyler

from bme280.

pabloandresm avatar pabloandresm commented on July 21, 2024

Thank you very much.

from bme280.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.