Git Product home page Git Product logo

Comments (3)

filips123 avatar filips123 commented on May 18, 2024 1

I added a check to only copy files to the profile if the global chrome/pwa/chrome.jsm is newer than the profile file. Because that file contains version, it should be automatically copied on every release. Always copying files can still be enabled in the extension settings. Note that on macOS it still copies files every time, because this is needed to properly set PWA name.

from pwasforfirefox.

filips123 avatar filips123 commented on May 18, 2024

It only overwrites/copies chrome/pwa and startupCache in the profile, and _autoconfig.cfg and defaults/pref/autoconfig.js in the Firefox installation (and some additional files on macOS, but this is actually needed on every launch so OS integration works correctly). I did this to make sure UserChrome stuff is always up-to-date, as updating them when package updates would be harder because user may have multiple OS and Firefox profiles.

Maybe the program could do this only when files actually differ from the latest installed version (C:\Program Files\FirefoxPWA\userchrome on Windows) but I'm not sure what the best way of checking if files need update would be. Perhaps it could check the hash/content of chrome/pwa/chrome.jsm as it contains package version which should be changed with every new release.

from pwasforfirefox.

kevonfernando avatar kevonfernando commented on May 18, 2024

What about a script that only runs on package updates/installations to reduce overwrites. Should that not be possible? Your idea also sounds good. Maybe you could do that with an extra version file. But to be honest, I do not know to much about this topic. This behaviour just stood out to me while I was messing with the files in chrome/pwa and thought I should tell you.

from pwasforfirefox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.