Git Product home page Git Product logo

Comments (8)

humphd avatar humphd commented on June 20, 2024 1

@bcheidemann ah, I see. We need to update https://github.com/filerjs/filer/blob/master/package.json#L77-L81 and potentially the build script to copy things where they are expected when you npm install filer. If you want to do that, that would be great.

from filer.

humphd avatar humphd commented on June 20, 2024

I've shipped v1.3.1 to npm, do you want to try that? https://github.com/filerjs/filer/releases/tag/v1.3.1

from filer.

thomas-jakemeyn avatar thomas-jakemeyn commented on June 20, 2024

Hello @humphd,

As far as I can see, the shims are still missing in the NPM library v1.3.1.
Also, I quickly checked the history and I could not find any commit that would have fixed this problem.

from filer.

humphd avatar humphd commented on June 20, 2024

cc @bcheidemann

from filer.

bcheidemann avatar bcheidemann commented on June 20, 2024

@humphd the "shims" directory in the root of the project needs to be released to NPM. Could you advise on what changes need to be made to facilitate this? Happy to put up a PR.

from filer.

bcheidemann avatar bcheidemann commented on June 20, 2024

@thomas-jakemeyn this is the workaround until the files are released to NPM:

  1. Copy the 'shims' directory from this repo into your project. This can be wherever you want but for arguments sake lets say you copy the contents to src/filer/shims.
  2. You then need to update the following imports:
// src/filer/shims/fs.js
// replace
const { FileSystem } = require('../src/index');
// with
const { FileSystem } = require('filer');

// src/filer/shims/path.js
// replace
const { path } = require('../src/index');
// with
const { path } = require('filer');

// src/filer/shims/providers/default.js
// replace
const { Default } = require('../../src/providers/index');
// with
const { Default } = require('filer/src/providers/index');

// src/filer/shims/providers/indexeddb.js
// replace
const IndexedDB = require('../../src/providers/indexeddb');
// with
const IndexedDB = require('filer/src/providers/indexeddb');

// src/filer/shims/providers/memory.js
// replace
const Memory = require('../../src/providers/memory');
// with
const Memory = require('filer/src/providers/memory');
  1. Instantiate the FilerWebpackPlugin class with the following options
// webpack.config.js
module.exports = {
  plugins: [
    new filer.FilerWebpackPlugin({
      shimsDir: '<rootDir>/src/filer/shims`,
    }),
  ],
}

This should work but I haven't tested it and I appreciate it's a lot of effort to go to. Hopefully it will be possible to release a new version of filer which includes the shims and webpack folders soon.

from filer.

humphd avatar humphd commented on June 20, 2024

Should be fixed by v1.4.1

from filer.

bcheidemann avatar bcheidemann commented on June 20, 2024

Confirmed, shims are now present :)

from filer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.