.test.js files have .js icons about vscode HOT 5 CLOSED

The same for the ts test files updated here: https://github.com/file-icons/atom/blob/4fbfdda/config.cson#L4002
Isn't it just a matter of updating the submodule?

from vscode.

The file extension matching works differently in vscode compared to atom. I've updated the icon list with upstream changes but I think it'll still show as a .js file

from vscode.

@DanBrooker thanks for looking into it but yes, .test.js files still show as .js files. Would it help if an extra line was added in the Atom repo with a specific regex so that this would work for VSCode (i.e. this would be redundant for Atom)? Or do you have another suggestion to tackle this (admittedly minor) inconvenience? I’d be happy to help where I can.

from vscode.

@lensbart there's a couple of things that could be done to improve the matching

1. more restrictive regex in the atom icon listings, i.e regex that generate > 1000 matches
2. some way of adding a regex match to vscode as plugin code or a PR to vscode
3. a json file of additions or overrides, it's simple and people could easily add to it, but it has a higher maintenance cost

from vscode.

Fixed in b6439ae (if not earlier…)

from vscode.