Git Product home page Git Product logo

Comments (5)

Alhadis avatar Alhadis commented on June 8, 2024 1

@hyperupcall The underlying issue hasn't been fixed; what you're seeing is the result of a curated list of manual corrections that lists the most commonly-used filenames of Webpack configs. It's a gross hack, but it's an effective stopgap until a more efficient pipeline can be implemented to sync this package with Atom's.

from vscode.

Meivyn avatar Meivyn commented on June 8, 2024

From Themes, Snippets and Colorizers:

fileNames associates file names to icons. The key in the set is the full file name, not including any path segments. Patterns or wildcards are not supported. File name matching is case insensitive. A 'fileName' match is the strongest match, and the icon associated to the file name will be preferred over an icon of a matching fileExtension and also of a matching language Id.

So you have to add all of its possible values into your icons theme file.

Example for webpack, based on vscode-icons:

  "fileNames": {
    "webpack.base.conf.js": "_webpack_medium-blue",
    "webpack.base.conf.coffee": "_webpack_medium-blue",
    "webpack.base.conf.ts": "_webpack_medium-blue",
    "webpack.common.js": "_webpack_medium-blue",
    "webpack.common.coffee": "_webpack_medium-blue",
    "webpack.common.ts": "_webpack_medium-blue",
    "webpack.config.js": "_webpack_medium-blue",
    "webpack.config.coffee": "_webpack_medium-blue",
    "webpack.config.ts": "_webpack_medium-blue",
    "webpack.config.base.js": "_webpack_medium-blue",
    "webpack.config.base.coffee": "_webpack_medium-blue",
    "webpack.config.base.ts": "_webpack_medium-blue",
    "webpack.config.common.js": "_webpack_medium-blue",
    "webpack.config.common.coffee": "_webpack_medium-blue",
    "webpack.config.common.ts": "_webpack_medium-blue",
    "webpack.config.dev.js": "_webpack_medium-blue",
    "webpack.config.dev.coffee": "_webpack_medium-blue",
    "webpack.config.dev.ts": "_webpack_medium-blue",
    "webpack.config.development.js": "_webpack_medium-blue",
    "webpack.config.development.coffee": "_webpack_medium-blue",
    "webpack.config.development.ts": "_webpack_medium-blue",
    "webpack.config.staging.js": "_webpack_medium-blue",
    "webpack.config.staging.coffee": "_webpack_medium-blue",
    "webpack.config.staging.ts": "_webpack_medium-blue",
    "webpack.config.test.js": "_webpack_medium-blue",
    "webpack.config.test.coffee": "_webpack_medium-blue",
    "webpack.config.test.ts": "_webpack_medium-blue",
    "webpack.config.prod.js": "_webpack_medium-blue",
    "webpack.config.prod.coffee": "_webpack_medium-blue",
    "webpack.config.prod.ts": "_webpack_medium-blue",
    "webpack.config.production.js": "_webpack_medium-blue",
    "webpack.config.production.coffee": "_webpack_medium-blue",
    "webpack.config.production.ts": "_webpack_medium-blue",
    "webpack.config.babel.js": "_webpack_medium-blue",
    "webpack.config.babel.coffee": "_webpack_medium-blue",
    "webpack.config.babel.ts": "_webpack_medium-blue",
    "webpack.config.base.babel.js": "_webpack_medium-blue",
    "webpack.config.base.babel.coffee": "_webpack_medium-blue",
    "webpack.config.base.babel.ts": "_webpack_medium-blue",
    "webpack.config.common.babel.js": "_webpack_medium-blue",
    "webpack.config.common.babel.coffee": "_webpack_medium-blue",
    "webpack.config.common.babel.ts": "_webpack_medium-blue",
    "webpack.config.dev.babel.js": "_webpack_medium-blue",
    "webpack.config.dev.babel.coffee": "_webpack_medium-blue",
    "webpack.config.dev.babel.ts": "_webpack_medium-blue",
    "webpack.config.development.babel.js": "_webpack_medium-blue",
    "webpack.config.development.babel.coffee": "_webpack_medium-blue",
    "webpack.config.development.babel.ts": "_webpack_medium-blue",
    "webpack.config.staging.babel.js": "_webpack_medium-blue",
    "webpack.config.staging.babel.coffee": "_webpack_medium-blue",
    "webpack.config.staging.babel.ts": "_webpack_medium-blue",
    "webpack.config.test.babel.js": "_webpack_medium-blue",
    "webpack.config.test.babel.coffee": "_webpack_medium-blue",
    "webpack.config.test.babel.ts": "_webpack_medium-blue",
    "webpack.config.prod.babel.js": "_webpack_medium-blue",
    "webpack.config.prod.babel.coffee": "_webpack_medium-blue",
    "webpack.config.prod.babel.ts": "_webpack_medium-blue",
    "webpack.config.production.babel.js": "_webpack_medium-blue",
    "webpack.config.production.babel.coffee": "_webpack_medium-blue",
    "webpack.config.production.babel.ts": "_webpack_medium-blue",
    "webpack.dev.js": "_webpack_medium-blue",
    "webpack.dev.coffee": "_webpack_medium-blue",
    "webpack.dev.ts": "_webpack_medium-blue",
    "webpack.dev.conf.js": "_webpack_medium-blue",
    "webpack.dev.conf.coffee": "_webpack_medium-blue",
    "webpack.dev.conf.ts": "_webpack_medium-blue",
    "webpack.prod.js": "_webpack_medium-blue",
    "webpack.prod.coffee": "_webpack_medium-blue",
    "webpack.prod.ts": "_webpack_medium-blue",
    "webpack.prod.conf.js": "_webpack_medium-blue",
    "webpack.prod.conf.coffee": "_webpack_medium-blue",
    "webpack.prod.conf.ts": "_webpack_medium-blue",
    "webpack.mix.js": "_webpack_medium-blue",
    "webpack.mix.coffee": "_webpack_medium-blue",
    "webpack.mix.ts": "_webpack_medium-blue",
    "webpack.test.conf.js": "_webpack_medium-blue",
    "webpack.test.conf.coffee": "_webpack_medium-blue",
    "webpack.test.conf.ts": "_webpack_medium-blue"
  },

Repeat for light. This fixed the icon for me.

from vscode.

Alhadis avatar Alhadis commented on June 8, 2024

So you have to add all of its possible values into your icons theme file.

That's absolutely ridiculous. Nobody should be doing that.

Does VSCode not enable users to customise things with plain old CSS, like Atom does?

from vscode.

DanBrooker avatar DanBrooker commented on June 8, 2024

Icon themes are very basic, full add-on could probably do regex matching.
The import script is currently getting the regex and generating all variations (except when it's too open)

from vscode.

hyperupcall avatar hyperupcall commented on June 8, 2024

Hmm, in the few years since the last comment it seems that this has somehow been fixed?

I disabled all extensions except this one, and it seems all the files have the correct icons (image below)

image

Maybe this isn't an issue with current versions of VSCode

from vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.