Git Product home page Git Product logo

Comments (5)

fholzer avatar fholzer commented on August 20, 2024 1

good point, will try to look into this in the next couple days

from docker-nginx-brotli.

onpaws avatar onpaws commented on August 20, 2024 1

Thanks @fholzer!
image
50% image size reduction seems nice.

Wanted to share a completely unscientific data point of the runtime memory difference as reported by docker stats.
I'm running just a SPA app -- local dev only, nothing production. So just a small/trivial data point, with that said, I was curious to see MEM USAGE
1.16.1
image

1.19.1
image

Could be completely unrelated to the Perl removal, not sure, but maybe it's possible there could be a small reduction in memory usage too.

Either way, nice work and danke!

from docker-nginx-brotli.

onpaws avatar onpaws commented on August 20, 2024

This appears to be the relevant commit that introduced the Perl module.
nginxinc/docker-nginx@89f7997

Curious, do you happen to know why Perl was introduced upstream? Maybe the nginx Docker maintainers are targeting specific customer(s) that use Perl?
Not having used Perl on the web since the Movable Type days it seems a bit unusual to ship it in the 'generic' nginx image. But perhaps there's a good reason; would be interested to learn why.

from docker-nginx-brotli.

onpaws avatar onpaws commented on August 20, 2024

@fholzer Not sure if you needed Perl for your purposes -- what are your thoughts? I ask b/c both @btmorex and an nginx Docker maintainer, @thresheek seem to avoid it:

the default "latest" or similar images do not have it.

nginxinc/docker-nginx@89f7997

Would you be open to a PR? What's your take on it?

from docker-nginx-brotli.

fholzer avatar fholzer commented on August 20, 2024

As perl is rarely used I'm more than OK with removing it from my image, though I won't be maintaining a separate image for it. I hope no one counts on it being supported.

Latest table stable and mainline version images are updated and no longer include perl:

  • latest (master/stable)
  • v1.18.0
  • mainline
  • v1.19.1 (still building)

from docker-nginx-brotli.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.