.concat returning invalid length when concating several empty arrays about ironjs HOT 6 CLOSED

I've finally gotten through my two crunch-weeks at work and got time to get back working on IronJS, I'll look into this ASAP and make sure we fix it within the next few days.

from ironjs.

So, the source of coffeescript says this:

if scope.expressions is this
      if o.scope.hasDeclarations()
        code += "#{@tab}var #{ scope.declaredVariables().join(', ') };\n"

The issue is certainly that o.scope.hasDeclarations() is returning a false positive. (not that there is a bug in CoffeeScript...)

The definitions of these in the coffeestript source is something like:

a.prototype.hasDeclarations = function () {
    return !!this.declaredVariables().length
}, a.prototype.declaredVariables = function () {
    var a, b, c, d, e, f;
    a = [], b = [], f = this.variables;
    for (d = 0, e = f.length; d < e; d++) c = f[d], c.type === "var" && (c.name.charAt(0) === "_" ? b : a).push(c.name);
        return a.sort().concat(b.sort())
}

My bet is on sort or concat causing issues. Not sure yet.

from ironjs.

Thanks for tracking this down @otac0n, i'm suspecting that there's something going on in that for-loop that isn't kosher with the IronJS parser (just saying, the bug is obviously in IronJS no doubt).

I'm betting either on sort and concat or some of the logic inside the loop.

from ironjs.

var a = [];
var b = [];
a.concat(b).length;

returns 1.

At this point, I'm almost certain that it is the concat function.

from ironjs.

This problem is fixed in 34584ac.
@otac0n: Thanks for locating the source function, finding the exact bug was easy once I knew where to look.

from ironjs.

awesome, thanks!

from ironjs.