Comments (3)
lukashornych
commented on June 24, 2024
1
@novoj the GQL support, tests and user documentation are done.
from evitadb.
novoj
commented on June 24, 2024
@lho the logic is prepared in method io.evitadb.api.requestResponse.data.PricesContract#getPriceForSaleWithAccompanyingPrices including basic tests. Please:
- add the logic to GraphQL API
- consider relevant support also in REST API
- add tests
- document usage in reference documentation (or transfer issue back to me after implementation on your side)
from evitadb.
novoj
commented on June 24, 2024
This issue changes behaviour of allPricesForSale and breaks backward compatibility for someone who relied on flawed implementation logic. Now the method mimics the calculation and behavior of priceForSale, which is more consistent.
from evitadb.
Related Issues (20)
- Entity fetching optimization
- Catalog references still leak memory
- Issues applying partial rollback in atomic entity mutation
- Ensure the computation is killed quickly when timeout is exceeded HOT 1
- Transaction pipeline finishing with exception
- Histogram values are not monotonic in Inverted histogram
- Support for layering configuration
- Exception when querying non-existent entity by unique attribute HOT 1
- Avoid certificate generation when no TLS endpoint is configured
- Catalog data file gets broken after compaction
- Query targeting localized attribute returns no result
- Referenced entity bodies are not returned for hierarchically fetched parents
- Selecting facet combination from different groups enables hasSense for invalid facets
- Allow custom price for sale parameters for `multiplePricesForSaleAvailable` field in GQL HOT 1
- Filter references without referenced objects (optionally)
- Support for disabling keep-alive header in configuration
- Unique ID identifying the catalog
- System status endpoint doesn't work
- SortIndex handles BigDecimal in wrong way
- System services for evitaLab
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evitadb.