Comments (6)
implemented in v1.19.0
from league_record.
seconding this. I would also love this feature.
How outplayed.tv approaches this is that you allocate X amount of space, and when you reach the limit specified, the old recordings start to be deleted in order to make space for it.
"Not deleting renamed videos" seems like a janky way to say "we should probably have a favoriting system so that the game appears at the top of the list and is not deleted" but its up to the dev to conclude if this is feature creep or not.
I have never programmed in rust, but am a somewhat experienced web developer, if the dev doesnt feel like it I might try my hand at rust haha 👀
from league_record.
I have an implementation of this feature in 9ef514d.
The "cleanup" currently only runs once when starting the app.
I still have to think about if I want to run the cleanup more often than that. Maybe before a game gets recorded?
This will be in the next release, when I finish the feature to mark recordings as "favorites" that dont get deleted.
from league_record.
I think a good que for cleanup is recording end. That way total size may still exceed a set limit, but only while a game is being recorded.
For even more accurate size control you could trigger a cleanup whenever writing more data to disk would exceed the limit, and continue writing only after in completes. Although memory usage may spike, depending on how long the cleanup takes.
from league_record.
I have an implementation of this feature in 9ef514d.
The "cleanup" currently only runs once when starting the app. I still have to think about if I want to run the cleanup more often than that. Maybe before a game gets recorded?
This will be in the next release, when I finish the feature to mark recordings as "favorites" that dont get deleted.
I'm not gonna lie, I dont think im the only one that boots up their pc and then plays league all day and doesn't have that much drive space left.
from league_record.
Alright the pre-release for this feature is out. https://github.com/FFFFFFFXXXXXXX/league_record/releases/tag/v1.19.0.
Usually I test this for a week myself before I release it, but since I currently don't have much time to play league I thought I would release it as a pre-release if you want to try it.
from league_record.
Related Issues (20)
- Game recording isnt working properly HOT 12
- Ultrawide support HOT 4
- Application randomly closing/crashing? HOT 21
- Startup at Windows startup HOT 9
- Void grubs- recorder crashing HOT 3
- videos don't show any info HOT 5
- ~1/10ish games not recording HOT 4
- Concerns about vanguard + question HOT 4
- Game not recording cause of change in settings? HOT 21
- [FEATURE REQUEST] Store whether "Classic" game is soloduo/flex/draft/quickplay HOT 2
- [FEATURE REQUEST] be able to turn on/off recording depending on gamemode HOT 11
- outputResolution not present by default in settings. HOT 4
- [BUG] Last 2 games have recorded loading screen and mouse movement for some reason HOT 3
- [bug] "no data" when finishing game with the webview open HOT 7
- [bug] Webview not updating with game that is just played unless leaguerecord is closed and reopened HOT 1
- Replay doesnt show Kills/Death/etc and Show No data HOT 15
- auto updating HOT 2
- No ingame event timeline for Arena mode
- Add YouTube upload support HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from league_record.