Git Product home page Git Product logo

Comments (6)

FFFFFFFXXXXXXX avatar FFFFFFFXXXXXXX commented on May 25, 2024 1

implemented in v1.19.0

from league_record.

ceselder avatar ceselder commented on May 25, 2024

seconding this. I would also love this feature.

How outplayed.tv approaches this is that you allocate X amount of space, and when you reach the limit specified, the old recordings start to be deleted in order to make space for it.

"Not deleting renamed videos" seems like a janky way to say "we should probably have a favoriting system so that the game appears at the top of the list and is not deleted" but its up to the dev to conclude if this is feature creep or not.

I have never programmed in rust, but am a somewhat experienced web developer, if the dev doesnt feel like it I might try my hand at rust haha 👀

from league_record.

FFFFFFFXXXXXXX avatar FFFFFFFXXXXXXX commented on May 25, 2024

I have an implementation of this feature in 9ef514d.

The "cleanup" currently only runs once when starting the app.
I still have to think about if I want to run the cleanup more often than that. Maybe before a game gets recorded?

This will be in the next release, when I finish the feature to mark recordings as "favorites" that dont get deleted.

from league_record.

btvoidx avatar btvoidx commented on May 25, 2024

I think a good que for cleanup is recording end. That way total size may still exceed a set limit, but only while a game is being recorded.

For even more accurate size control you could trigger a cleanup whenever writing more data to disk would exceed the limit, and continue writing only after in completes. Although memory usage may spike, depending on how long the cleanup takes.

from league_record.

ceselder avatar ceselder commented on May 25, 2024

I have an implementation of this feature in 9ef514d.

The "cleanup" currently only runs once when starting the app. I still have to think about if I want to run the cleanup more often than that. Maybe before a game gets recorded?

This will be in the next release, when I finish the feature to mark recordings as "favorites" that dont get deleted.

I'm not gonna lie, I dont think im the only one that boots up their pc and then plays league all day and doesn't have that much drive space left.

from league_record.

FFFFFFFXXXXXXX avatar FFFFFFFXXXXXXX commented on May 25, 2024

Alright the pre-release for this feature is out. https://github.com/FFFFFFFXXXXXXX/league_record/releases/tag/v1.19.0.
Usually I test this for a week myself before I release it, but since I currently don't have much time to play league I thought I would release it as a pre-release if you want to try it.

from league_record.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.