Comments (8)
Splitting off a separate package shouldn't be necessary for this. Just importing the withFit
-mixin directly will be enough. :)
We never import redux directly in any of the mixins (just the TS types) nvm I forgot bindActionCreators
, but that's in connect
, not in withFit
. :)
from fit-html.
Ok, I got it. That's cool.
from fit-html.
BTW, is 3Kb
still correct now? I just get a 20Kb bundle file(fit-html, lit-html, and redux) and an 8Kb compressed file. @NeoLegends
from fit-html.
BTW, is 3Kb still correct now? I just get a 20Kb bundle file(fit-html, lit-html, and redux) and an 8Kb compressed file. @NeoLegends
3k was always minzipped size, but that sounds a little large, tbh. fit-html hasn't changed in size very much lately, but lit-html and maybe redux have. How many components are there in your bundle? You may underestimate the size of the template strings. Also, are you using a tree-shaking bundler (webpack 2, rollup)?
from fit-html.
Yeah, I check the bundle file, it's not fit-html
's fault. lit-html
increase a lot during recent versions.
from fit-html.
Great! Mind sharing the stats? Iād be interested in how large lit-html has become by now. :)
from fit-html.
I write the index.ts and import lit-html (v0.10), use rollup to build bundle.
import { html } from 'lit-html/lib/lit-extended';
console.log(html)
minized size: 5.2Kb
minized and gizped size: 1.9Kb
from fit-html.
I'm afraid you're missing the render
from lit-html
to get more accurate stats about the size. Right now you're just importing the tag, but no render functionality.
from fit-html.
Related Issues (7)
- Action required: Greenkeeper could not be activated šØ HOT 1
- `connect` may wrongly detect a factory function in `mapStateToProps` HOT 3
- Usage without redux
- An in-range update of rollup-plugin-commonjs is breaking the build šØ HOT 11
- An in-range update of rollup-plugin-replace is breaking the build šØ HOT 3
- An in-range update of bundlesize is breaking the build šØ HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fit-html.