Comments (3)
On further investigation, I had no issue with deepMap (I was initially trying to do deepMap on already precompiled react code, so perhaps this influenced the results).
However it appears that deepFind does go deep, but it misses out several node.
from react-children-utilities.
Thanks @McPo for taking the time to add this issue. Do you have an example where deepFind is missing nodes?
from react-children-utilities.
@McPo I've revised deepFind and I couldn't find an example which avoids nodes.
Just for you to know it doesn't traverse by tree level, it goes as deep possible on each node so let's say we have
const DeepFound = props => (<div>{ Children.deepFind(props.children, child => child.type === 'i') }</div>);
and we want to test it on this:
<DeepFound>
<b>1</b>
<b><span><i>2</i></span></b>
<span><i>3</i></span>
<i>4</i>
</DeepFound>);
In this case the nodes visited would be b -> b -> span -> i
and it would end there on the i with text 2, the rest of the nodes would have never been visited.
from react-children-utilities.
Related Issues (20)
- Can't resolve 'react' HOT 1
- deepFind should return the element found, not its root HOT 1
- Issues with "deep children" (aka children within other component) HOT 5
- Build issue during Jest tests when importing react-children-utilities HOT 12
- deepMap, deepFind and deepForEach do not use index & children arguments HOT 5
- onlyText: reduce calls of validate fn HOT 4
- onlyText does not support self closing children
- ESM issue 😬 HOT 21
- Deepmap nested children HOT 3
- Compilation errors when building with webpack 5 HOT 11
- groupByType support UppercaseComponent, not only lowercase like div + span HOT 8
- Problem with husky on npm 7.20.* HOT 2
- getElementName is not exported HOT 1
- deepFilter doesn't match to grandchildren HOT 4
- `deepMap` not iterating over elements with only text as children. HOT 3
- `deepForEachFn` does not accept `children` argument as mentioned in the docs. HOT 2
- ts type HOT 6
- react 18 support request HOT 1
- deepFilter recursion failed on user defined Component HOT 2
- Support named imports by exporting named constants HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-children-utilities.