Comments (8)
Huh. I thought at one point all were required to be hyphenated because they could in future be thought of as individual imports, though I am not sure we worry about that any more. @lann any idea why these are required to be snaked?
from spin.
Yeah, Fermyon cloud currently requires them to be hyphenated, so i was surprised by Spin having a different requirement
from spin.
I don't remember exactly how we ended up in this situation but it would be good if labels could be represented as kebab-case, either by requiring them to be kebab-case themselves or having a simple rule to convert them.
from spin.
To prevent a breaking change, we probably cannot change pub key_value_stores: Vec<SnakeId>
to pub key_value_stores: Vec<KebabId>
but as you mention, @lann we could add custom serialization.
from spin.
What is the outcome here (for the 2.x timeframe) - allow kebab or snake case?
I don't quite get the discussion around converting. Is the idea that internally they'd be represented as kebab-ids? And we would also convert snakeful references (e.g. Store::open("my_snek")
) to match the kebab-id?
from spin.
I guess my perspective is that I don't want to make major breaking changes to the manifest format but it would be good to have a plan for how to map labels to kebab-case names in the future, which could involve making minor changes to the label validation rules (in particular, kebab-case "words" between -
s cannot start with a number).
from spin.
For now, could we change the manifest to allow kebab or snake case and then when we are ready to break, we remove snake? Fermyon cloud can continue to only support kebab
from spin.
WFM but I don't currently have a good mental model of how all these things currently work so I'll defer to others.
from spin.
Related Issues (20)
- spin watch doesn't rebuild/reconfigure on manifest file changes HOT 6
- Different execution times for python spin app on local machine and Fermyon Cloud HOT 6
- Sleeping in a Spin app breaks traces HOT 1
- Templates: support Cargo workspaces
- Upcoming Security Release of Spin (GHSA-f3h7-gpjj-wcvh) HOT 1
- Support exporting application logs through OTel HOT 2
- spin-v2.4.3-macos-amd64.tar.gz contains the wrong architecture HOT 4
- Template install and upgrade commands use different option for Git/URL.
- Dynamically set service name for OTel resource
- `files` manifest option should warn when `destination` does not appear to be a directory HOT 3
- Consider using `http-acl` for enforcing `allowed-outbound-hosts`
- Enhance React application performance to run on embedded devices. HOT 3
- Received runtime error that should be thrown at component build time HOT 1
- Raspberry Pico HOT 1
- [OTel]: Spans produced by `spin_sdk::key_value::Store::set` don't have a parent assigned HOT 3
- Provide multiple entries as a variable for lists in 'spin.toml' HOT 15
- Add escape syntax to variables expansion syntax (`spin-expressions`) HOT 5
- Provide the ability to import manifest and runtime-config as wasm modules (components) HOT 8
- oci loader related problems with spinkube HOT 3
- Push component to registry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spin.