Git Product home page Git Product logo

Comments (8)

itowlson avatar itowlson commented on June 2, 2024

Huh. I thought at one point all were required to be hyphenated because they could in future be thought of as individual imports, though I am not sure we worry about that any more. @lann any idea why these are required to be snaked?

from spin.

kate-goldenring avatar kate-goldenring commented on June 2, 2024

Yeah, Fermyon cloud currently requires them to be hyphenated, so i was surprised by Spin having a different requirement

from spin.

lann avatar lann commented on June 2, 2024

I don't remember exactly how we ended up in this situation but it would be good if labels could be represented as kebab-case, either by requiring them to be kebab-case themselves or having a simple rule to convert them.

from spin.

kate-goldenring avatar kate-goldenring commented on June 2, 2024

To prevent a breaking change, we probably cannot change pub key_value_stores: Vec<SnakeId> to pub key_value_stores: Vec<KebabId> but as you mention, @lann we could add custom serialization.

from spin.

itowlson avatar itowlson commented on June 2, 2024

What is the outcome here (for the 2.x timeframe) - allow kebab or snake case?

I don't quite get the discussion around converting. Is the idea that internally they'd be represented as kebab-ids? And we would also convert snakeful references (e.g. Store::open("my_snek")) to match the kebab-id?

from spin.

lann avatar lann commented on June 2, 2024

I guess my perspective is that I don't want to make major breaking changes to the manifest format but it would be good to have a plan for how to map labels to kebab-case names in the future, which could involve making minor changes to the label validation rules (in particular, kebab-case "words" between -s cannot start with a number).

from spin.

kate-goldenring avatar kate-goldenring commented on June 2, 2024

For now, could we change the manifest to allow kebab or snake case and then when we are ready to break, we remove snake? Fermyon cloud can continue to only support kebab

from spin.

lann avatar lann commented on June 2, 2024

WFM but I don't currently have a good mental model of how all these things currently work so I'll defer to others.

from spin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.