Git Product home page Git Product logo

Comments (6)

fereidani avatar fereidani commented on July 28, 2024 1

Thanks for the report! I really appreciate your contributions to Kanal with reporting these bugs.
I don't think that's because of clone_sync.
I'm going to investigate this report and will let you know what was the problem.
Miri reports :

    |
224 |         self.ptr.as_ptr()
    |         ^^^^^^^^ using uninitialized data, but this operation requires initialized memory
    |

from kanal.

beckend avatar beckend commented on July 28, 2024

you might as well write tests for .clone_async() to make sure it does not have the same bug.

from kanal.

fereidani avatar fereidani commented on July 28, 2024

Nice catch, there was a race condition in the read future, that actually lead to finding another race condition in send future too!
Both are patched with f615c8c .
Could you please run your test with the following and check if the problem is solved?

[dependencies]
kanal = {git="https://github.com/fereidani/kanal"}
tokio = { version = "1", features = ["full"] }
anyhow = "*"

from kanal.

beckend avatar beckend commented on July 28, 2024

Nice! It works, closing, please do a release.

from kanal.

fereidani avatar fereidani commented on July 28, 2024

Sure, will do that tomorrow, I need to rerun benchmarks and additional tests.
If it's possible for you for the next reports please use Tokio like this:

fn main() {
    let rt = tokio::runtime::Builder::new_current_thread()
        .enable_time()
        .build()
        .unwrap();
    rt.block_on(async_fn()).unwrap();
}

because it is easier to debug this one using Miri and other debug tools.

from kanal.

beckend avatar beckend commented on July 28, 2024

No problem

from kanal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.