Lost wake-ups due to race about kanal HOT 4 CLOSED

Hi, Thanks for the issue, I found some dead code in the project because of it, But it's incorrect, Waker is registered here before pushing the signal to the signal list:

and this code was a dead code that I forgot to remove:

     { 
         self.waker = Some(cx.waker().clone()) 
     } 

so before pushing the signal to the queue, the waker is already registered, and the possibility of lost wake-ups does not exist.

Feel free to close the issue if you think my explanation is clear.

from kanal.

So as I wrote in the sibling issue: you need to re-register the waker every time because it can change every time poll is called, so the dead code was actually something that should be done, albeit safely.

from kanal.

Let's continue that subject in #14

from kanal.

Fixed as discussed in #14

from kanal.