Git Product home page Git Product logo

Comments (3)

fengdai avatar fengdai commented on August 17, 2024

Hi @cbeyls . For now, I only target v21. If you want to use v20, you can modify the code yourself. It's very easy.

from alertdialogpro.

fengdai avatar fengdai commented on August 17, 2024

BTW. I think making the core inherit from the native themes directly is not a good idea. Using Theme.AppCompat.Dialog (Whatever v20 or 21) can give dialog a coincident appearance on different platform versions.

from alertdialogpro.

cbeyls avatar cbeyls commented on August 17, 2024

Yes, I was actually suggesting to copy all the Dialog-related styles of AppCompat to your library, in order to have a consistent appearance while also being compatible with v20. But after looking at the source of these styles in detail I realized that there is a lot to copy and the styling is really optimized for Material, so it's a good thing that your library reuses that and I understand the requirement. I'll try to migrate my project to AppCompat v21 soon.

Thank you for your reply and for your work.

from alertdialogpro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.