Searching for workspace symbols is super slow about php-language-server HOT 3 CLOSED

Yes, noticed that too. That is because before we had all ASTs in memory. Now we only have a FQN => URI map. But for SymbolInformations, we need the locations and types of those symbols. So we first apply the query to the FQNs, and then for all FQNs that matched, load the document at the URI and find out the location/type. And because IO in PHP is sync (we could make it async though) it is done in serial. So the less specific your query is, the longer it takes.

I would like to also keep a table of SymbolInformations to speed this up.

from php-language-server.

I will just change the map to FQN => SymbolInformation then because a SymbolInformation includes the URI

from php-language-server.

@felixfbecker Yes, I think having SymbolInformations array would be good compromise between keeping only FQN => URI and ASTs in memory.

from php-language-server.