Formatter removes EEx comment tags about heex_formatter HOT 7 CLOSED

Unfortunately it's stripping out the comments from the original code and now is also inserting an indented blank line

<div>
  
</div>

from heex_formatter.

@feliperenan we need to call Code.string_to_quoted_with_comments and then pass the :comments option in Code.quoted_to_algebra. (This is separate from the original issue).

from heex_formatter.

The main issue is now fixed on main but depends on Elixir 1.14 that is yet to be released.

PS: You should comment your code using <%!-- comment --%> syntax because <%# comment %> will be deprecated soon. The previous work around should work.

from heex_formatter.

Hi @mulias

Thanks for reporting this. I'm working in a refactor to use Inspect.Algebra module to format the code. Hopefully this issue will be solved once I'm done with that.

from heex_formatter.

This will have to be fixed in Elixir and therefore wait for a new Elixir version. :(

@feliperenan let me know if you want to contribute this feature upstream!

from heex_formatter.

I do!😊. I will probably start to take a look at from tomorrow's on.

from heex_formatter.

Quick update, since my initial description is no longer correct

case 1 input:

    <div>
      <%# some %>
      <%# comment %>
      <%# lines %>
    </div>

output:

  <div>
    
  </div>

case 2 input:

    <div>
      <% # some %>
      <% # comment %>
      <% # lines %>
    </div>

output:

  <div>
    <%  %>
    <%  %>
    <%  %>
  </div>

case 3 input:

    <div>
      <%= # some %>
      <%= # comment %>
      <%= # lines %>
    </div>

output:

  <div>
    <%=  %>
    <%=  %>
    <%=  %>
  </div>

The workaround mentioned above no longer works, but everything else seems to be working great!

from heex_formatter.