Somehow, it translates URLs in Markdown as well. I am not certain how to fix that, but

For this English text, for example: <div class="highlight highlight-text-md notran

The format Service is implemented here: <a href="https://github.com/Fekide/strapi-plug

This is my config: <div class="highlight highlight-source-js notranslate position-

I have just tried it with the following string: <div class="highlight highlight-te

Do not translate URLs in Markdown about strapi-plugin-translate HOT 11 CLOSED

adriaandotcom commented on June 3, 2024

Do not translate URLs in Markdown

from strapi-plugin-translate.

Comments (11)

sargreal commented on June 3, 2024 1

Okay that looks fine.

I think your suggestion with replacing links is the best way of doing it right now, but I will investigate further. I will fix it however probably not until next week.

from strapi-plugin-translate.

adriaandotcom commented on June 3, 2024 1

For this English text, for example:

Data protection authorities [coordinated their approach at a European level](https://edpb.europa.eu/news/news/2020/european-data-protection-board-thirty-seventh-plenary-session-guidelines-controller_en) to handle the complaints coherently.
As a result, the [Austrian](https://gdprhub.eu/index.php?title=DSB_(Austria)_-_2021-0.586.257_(D155.027)), [French](https://gdprhub.eu/index.php?title=CNIL_(France)_-_Google_Analytics_(no_case_number)), [Italian](https://gdprhub.eu/index.php?title=Garante_per_la_protezione_dei_dati_personali_(Italy)_-_9782890), and [Hungarian](https://gdprhub.eu/index.php?title=NAIH_(Hungary)_-_NAIH-3561-4/2022) DPAs ruled against the use of Google Analytics in very similar decisions, and the Danish DPA essentially did the same in a [press release](https://www.datatilsynet.dk/english/google-analytics/use-of-google-analytics-for-web-analytics).
While the decisions address an individual controller, they all set a precedent that **practically amounts to a State-wide ban**, as we explained [here](https://www.simpleanalytics.com/blog/is-google-analytics-illegal-in-europe#2-what-did-the-authorities-actually-say). Should the CNPD do the same, its decision would set a similar precedent for Portugal.

Translation to Italian:

Le autorità di protezione dei dati [hanno coordinato il loro approccio a livello europeo](<https://edpb.europa.eu/news/news/2020/european-data-protection-board-thirty-seventh-plenary-session-guidelines-controller_en>) per gestire i reclami in modo coerente.
Di conseguenza, le autorità [austriache](<https://gdprhub.eu/index.php?title=DSB_(Austria)_-_2021-0.586.257_(D155.027>)), [francesi](<https://gdprhub.eu/index.php?title=CNIL_(Francia)_-_Google_Analytics_(no_case_number>)), [italiane](<https://gdprhub.eu/index.php?title=Garante_per_la_protezione_dei_dati_personali_(Italia)_-_9782890>) e [Ungherese](<https://gdprhub.eu/index.php?title=NAIH_(Ungheria)_-_NAIH-3561-4/2022>) le DPA si sono pronunciate contro l'uso di Google Analytics in decisioni molto simili, e la DPA danese ha sostanzialmente fatto lo stesso in un [comunicato stampa](<https://www.datatilsynet.dk/english/google-analytics/use-of-google-analytics-for-web-analytics>).
Sebbene le decisioni riguardino un singolo controllore, tutte stabiliscono un precedente che **praticamente equivale a un divieto a livello statale**, come abbiamo spiegato [qui](<https://www.simpleanalytics.com/blog/is-google-analytics-illegal-in-europe#2-what-did-the-authorities-actually-say>). Se la CNPD dovesse fare lo stesso, la sua decisione creerebbe un precedente simile per il Portogallo.

It looks like if links have brackets in them, like [French](https://gdprhub.eu/index.php?title=CNIL_(France)_-_Google_Analytics, it breaks.

from strapi-plugin-translate.

sargreal commented on June 3, 2024

The format Service is implemented here: plugin/server/services/format.js

I had expected that the html translation would not translate the links. Is the content getting translated or also the href (i.e. what is in the braces in markdown)?

from strapi-plugin-translate.

adriaandotcom commented on June 3, 2024

also the href (i.e. what is in the braces in markdown)?

This as well. Translating the content is fine of course, but the link itself should stay the same, I guess.

from strapi-plugin-translate.

sargreal commented on June 3, 2024

Just to verify, you have used or not overwritten this in the config right?

translatedFieldTypes: [
  // ...
  { type: 'richtext', format: 'markdown' },
  // ...
],

from strapi-plugin-translate.

adriaandotcom commented on June 3, 2024

This is my config:

// config/plugins.js
{
  translate: {
    enabled: true,
    config: {
      provider: "deepl",
      providerOptions: {
        apiKey: env("DEEPL_API_KEY"),
        freeApi: env("DEEPL_API_FREE") === "true",
        apiUrl: "https://api.deepl.com",
      },
      translatedFieldTypes: [
        "string",
        { type: "text", format: "plain" },
        { type: "richtext", format: "markdown" },
      ],
      translateRelations: true,
    }
  }
}

Thanks for looking into it.

from strapi-plugin-translate.

sargreal commented on June 3, 2024

I have just tried it with the following string:

[very important link](https://important.link/with-many/english-words/that-could-be-translated)

and it got translated as expected to:

[sehr wichtiger Link](<https://important.link/with-many/english-words/that-could-be-translated>)

@adriaanvanrossum can you please provide an example where it doesn't work?

from strapi-plugin-translate.

fekide-bot commented on June 3, 2024

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

from strapi-plugin-translate.

fekide-bot commented on June 3, 2024

🎉 This issue has been resolved in version 1.1.0-next.2 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

from strapi-plugin-translate.

fekide-bot commented on June 3, 2024

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

from strapi-plugin-translate.

fekide-bot commented on June 3, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

from strapi-plugin-translate.

Do not translate URLs in Markdown about strapi-plugin-translate HOT 11 CLOSED

Comments (11)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent