Git Product home page Git Product logo

Comments (4)

woop avatar woop commented on May 22, 2024

@zhilingc can you highlight the method you are referring to (for extension)?

from feast.

zhilingc avatar zhilingc commented on May 22, 2024

From:

rpc ApplyFeature(feast.specs.FeatureSpec) returns (CoreServiceTypes.ApplyFeatureResponse) {};

To:

rpc ApplyFeature(CoreServiceTypes.ApplyFeatureRequest) returns (CoreServiceTypes.ApplyFeatureResponse) {};

message ApplyFeatureRequest {
  feast.specs.FeatureSpec spec = 1;
  bool update = 2;
}

I'm not sure if i prefer this solution actually.

from feast.

woop avatar woop commented on May 22, 2024

Well, multiple things:

  • A better abstraction would be ApplyResource or UpdateResource, otherwise we will reinvent this for all resource types. But if we take that logic further...
  • If we eventually intend to move to Kubernetes for managing our resources, then we are basically reinventing the resources management within it. It might be easier to just move all of this into CRDs, and then Feast just becomes a proxy to these requests.

from feast.

woop avatar woop commented on May 22, 2024

This issue isn't relevant any more due to changes in Feast 0.3.0

from feast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.