Git Product home page Git Product logo

Comments (4)

fcevado avatar fcevado commented on June 3, 2024

it should work for cellphones too. recently support for regional codes for spanish numbers were added. I'll need to take a look at the regexes there. @ferigis if you know how to fix it, i'm glad to merge your changes.
can you point me to the spanish numbering plan in english? it would make it easier.

from phone.

luhalvesbr avatar luhalvesbr commented on June 3, 2024

Hello lads,
I am just seeing this problem... It looks like the code is not treating the mobile phones in 🇪🇸
(My bad, the change I had sent previously didn’t include the format @fcevado )

@ferigis, correct if I am getting it wrong but the format for mobile number in Spain should be:

+34 6XY...
+34 71Y...
+34 72Y...
+34 73Y...
+34 74Y...
(X and Y can be any digit from 0 to 9)

So, we are gonna have this format:

Any suggestions on how to return the following keys?
area_abbreviation, area_code, area_name, area_type

I can send a PR with this small change soon 🔥
Thanks, y'all!

from phone.

fcevado avatar fcevado commented on June 3, 2024

@luhalvesbr a simple way to solve it is to create a Phone.ES.Mobile as the way it's done for toll free numbers for Brazil or NANP.
just an example:
https://github.com/fcevado/phone/blob/main/lib/phone/br/toll_free.ex

from phone.

fcevado avatar fcevado commented on June 3, 2024

fixed by #140

from phone.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.