__slots__ are ignored about mashumaro HOT 7 CLOSED

Fixed in 2.2.

from mashumaro.

Hello @zupo. Thank you for creating this issue.

I came up with the idea of adding empty __slots__ to the parent classes to fix this issue. It seems to work and helps to reduce memory consumption. You can check this branch https://github.com/Fatal1ty/mashumaro/tree/slots.

from mashumaro.

Hmm, I tried, but it doesn't seem to work?

from mashumaro.

Hmm, I tried, but it doesn't seem to work?

I checked your example in the new branch and it fails as it should with AttributeError: 'Bar' object has no attribute 'new_attribute'. The slots test also passes on different Python versions. Can you shed some light on what's not working?

from mashumaro.

Gosh, I'm terribly sorry for the noise, it was a mistake on my end. Works as expected!

from mashumaro.

Gosh, I'm terribly sorry for the noise, it was a mistake on my end. Works as expected!

I don't think it would work without adding __slots__ to DataClassDictMixin and other derived parent classes like DataClassJSONMixin. I was going to release a fix for that but now I'm confused :)

from mashumaro.

543356e is definitely needed.

I was not using the correct branch when I first tested (I thought I did) and now I re-checked and works as expected with the slots branch.

I closed the issue by mistake. Getting late, I should go to bed.

from mashumaro.