Git Product home page Git Product logo

Comments (11)

level420 avatar level420 commented on June 11, 2024

Forgot to say: this is a migration from 1.5 to 2.5.19

from jupgradepro.

fastslack avatar fastslack commented on June 11, 2024

Are you using database or RESTful method?

Is strange that you have numnews column on your Joomla! 1.5 schema. Its not by default.

from jupgradepro.

level420 avatar level420 commented on June 11, 2024

I'm using the RESTfull method.
No idea where the column comes from. Mabe from Joomfish?

from jupgradepro.

fastslack avatar fastslack commented on June 11, 2024

Sorry, seems that numnews yes is there by default :-P So this patch bb3038a sort that issue.

Thanks for reporting

from jupgradepro.

level420 avatar level420 commented on June 11, 2024

Thank you for fixing this.

Would you mind fixing also the pre bug where the reportError method is missing in JUpgradeproModelMigrate?
If I didn't had the knowledge to catch the error message with error_log I'd never seen what caused the problem. A normal user only sees that the migration stopped, without getting an error message.

Thank you.

Best regards...

from jupgradepro.

fastslack avatar fastslack commented on June 11, 2024

Are you enabling the debug?

from jupgradepro.

level420 avatar level420 commented on June 11, 2024

Sorry for being late with my answer.

Yes! I've set:

"Enable PHP error_reporting" -> Yes
"Debug checks and cleaup" -> Yes
"Debug steps" -> Yes
"Debug migration" -> Yes.

The last message I'm seeing is:

[STEP modules]

{"id":"10","name":"modules","title":"Core Modules","class":"JUpgradeproModules","tbl_key":"id","source":"modules","destination":"modules","cid":"0","status":"1","total":"21","start":"0","stop":"20","laststep":"weblinks","chunk":"100","first":"1","old_ver":"1.5","_table":"#__jupgradepro_steps","debug":"{{{5}}}"}

from jupgradepro.

level420 avatar level420 commented on June 11, 2024

I'm sorry but I've tested your fix which did not work because it tested for the target installationto be greater or equal 3.0, which does not apply to my case where the target ist Joomla 2.5. So I think the fix should be:

if (version_compare(JUpgradeproHelper::getVersion('new'), '2.5', '>='))
unset($row->numnews);

from jupgradepro.

fastslack avatar fastslack commented on June 11, 2024

Fixed now. Thanks! b71c89a

from jupgradepro.

level420 avatar level420 commented on June 11, 2024

Thank you for the fix!

But this does not fix the missing reportError method problem.

I think this should be fixed as well!

Regards
level420

from jupgradepro.

fastslack avatar fastslack commented on June 11, 2024

Added the missing functions. eb46e95

from jupgradepro.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.