Comments (1)
It sounds like a good idea. Here are 2 complementing ideas to your proposal:
- we try detect the default branch name.
def default_git_branch
default_branch = Fastlane::Actions.git_remote_branch_name(nil)
default_branch = default_branch.split("\n")[0] if default_branch
default_branch ||= "main"
end
or
def default_git_branch
begin
first_remote = Fastlane::Actions.sh("git remote | head -1", log: false).chomp
default_branch = Fastlane::Actions.git_remote_branch_name(first_remote)
rescue => e
end
default_branch ||= "main"
end
Also I am using here "main" as default branch. Any reason we should stick to master? We will eventually have to change, right?
Side note: I wish the git_remote_branch_name
method was fixed to only return the head of the first remote. We could maybe add a fix for that first. It doesn't really make sense to return a "master\nmaster" if you have 2 remotes with master as default branch. It would also make this code simpler, something like
def default_git_branch
default_branch = Fastlane::Actions.git_remote_branch_name(nil)
default_branch ||= "main"
end
- if we really want to ask the user, we could combine asking the user and identifying the default_branch using the above code as first default choice.
Feel free to start your PR, consider using one of the 2 options above.
from fastlane.
Related Issues (20)
- Fastlane is not reading macros from Package.Swift (SPM)
- fastlane sigh download_all and "Error parsing provisioning profile at path..."
- fastlane match HOT 4
- bundler: command not found: fastlane
- Individual API Key not supported HOT 3
- fastlane deliver init is not working in CLI
- JEG2/highline should be updated to avoid warning of abbrev missing in standard lib for ruby 3.3.0
- How to get raw exit code from Fastlane HOT 1
- Match import to s3 Crash on encrypting. HOT 2
- Provisioning profile expiration comparison compares Time and DateTime
- AvailableTerritories is deprecated and fastlane is not upgraded to new api endpoints HOT 5
- Match managing provisioning profiles for DriverKit
- curb-1.0.0/lib/curl/easy.rb - Failed to read/open file
- `match` behaves differently in v2.220.0: `wrong final block length` HOT 12
- Can't upload build to Test Flight; [!] undefined method `refresh!' HOT 2
- A parameter has an invalid value - 'prices' is not a valid relationship name HOT 9
- I run the command 'fastlane match development'. and i got the following error: Looking for related GitHub issues on fastlane/fastlane... Found no similar issues. To create a new issue, please visit: https://github.com/fastlane/fastlane/issues/new Run fastlane env to append the fastlane environment to your issue [!] The request could not be completed because: This request is forbidden for security reasons - You currently don't have access to this membership resource. Contact your team's Account Holder, or an Admin.
- Build_for_testing fails sporadically with error 'Could not find or use auto-linked framework' HOT 2
- Can fastlane support filling in Chinaโs ICP registration number?
- [match] provisioning profile generated via match blocks release installation on TestFlight (or on device) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastlane.