Git Product home page Git Product logo

Comments (6)

KrauseFx avatar KrauseFx commented on June 17, 2024

@lferro9000 I agree that the stack trace is usually not needed, but if a user reports an issue it is super helpful for me to see the full stack trace to resolve the issue 👍

from frameit.

lferro9000 avatar lferro9000 commented on June 17, 2024

The idea is to squelsh it only for that use case (image found without the corresponding texts).

from frameit.

KrauseFx avatar KrauseFx commented on June 17, 2024

Could you share an example output?

from frameit.

lferro9000 avatar lferro9000 commented on June 17, 2024
[15:37:33]: Could not get title for screenshot ./en-UK/LoadingScreen-iphone6.png. Please provide one in your Framefile.json
[15:37:33]: Backtrace:
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:273:in `fetch_text'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:211:in `block in build_title_images'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:211:in `keep_if'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:211:in `build_title_images'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:156:in `add_title'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:102:in `complex_framing'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:17:in `frame!'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/screenshot.rb:72:in `frame!'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/runner.rb:29:in `block in run'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/runner.rb:21:in `each'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/runner.rb:21:in `run'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/bin/frameit:33:in `block (2 levels) in run'
    /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
    /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
    /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
    /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
    /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
    /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/bin/frameit:57:in `run'
    /Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/bin/frameit:65:in `<top (required)>'
    /usr/bin/frameit:23:in `load'
    /usr/bin/frameit:23:in `<main>'

This is the output of one of the missing images. The backtrace is not that helpful in just this kind of cases. And the error message should point to the language files keyword.strings and title.strings (inside the respective languages) not just the Framefile.json.

from frameit.

KrauseFx avatar KrauseFx commented on June 17, 2024

This will be fixed in the next release 👍

from frameit.

fastlanebot avatar fastlanebot commented on June 17, 2024

This issue was migrated to fastlane/fastlane#2765. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

from frameit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.