Comments (6)
@lferro9000 I agree that the stack trace is usually not needed, but if a user reports an issue it is super helpful for me to see the full stack trace to resolve the issue 👍
from frameit.
The idea is to squelsh it only for that use case (image found without the corresponding texts).
from frameit.
Could you share an example output?
from frameit.
[15:37:33]: Could not get title for screenshot ./en-UK/LoadingScreen-iphone6.png. Please provide one in your Framefile.json
[15:37:33]: Backtrace:
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:273:in `fetch_text'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:211:in `block in build_title_images'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:211:in `keep_if'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:211:in `build_title_images'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:156:in `add_title'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:102:in `complex_framing'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/editor.rb:17:in `frame!'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/screenshot.rb:72:in `frame!'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/runner.rb:29:in `block in run'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/runner.rb:21:in `each'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/lib/frameit/runner.rb:21:in `run'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/bin/frameit:33:in `block (2 levels) in run'
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/bin/frameit:57:in `run'
/Library/Ruby/Gems/2.0.0/gems/frameit-2.2.0/bin/frameit:65:in `<top (required)>'
/usr/bin/frameit:23:in `load'
/usr/bin/frameit:23:in `<main>'
This is the output of one of the missing images. The backtrace is not that helpful in just this kind of cases. And the error message should point to the language files keyword.strings and title.strings (inside the respective languages) not just the Framefile.json.
from frameit.
This will be fixed in the next release 👍
from frameit.
This issue was migrated to fastlane/fastlane#2765. Please post all further comments there.
fastlane
is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀
from frameit.
Related Issues (20)
- Wrong baseline HOT 1
- Frameit always skips the same screenshot HOT 5
- Support for Android HOT 6
- undefined method `split' for nil:NilClass for OS X screenshots HOT 4
- suggestion: support facebook's frames HOT 1
- Can't read strings from 'title.strings' HOT 12
- Error installing frameit on OSX El Capitan 10.11 HOT 1
- First screenshot always causes problems HOT 1
- Font size percentage and keyword position HOT 1
- Option to Disable white space trimming HOT 4
- add different background for a specific screenshot HOT 2
- Request for more flexible title styling format HOT 1
- Title and keyword discard color option HOT 1
- Framing screenshots at path error HOT 1
- Framed photos unable to be submitted through deliver HOT 10
- Alternative device frame location doesn't seem to work HOT 1
- Is there the ability to have landscape backgrounds with portrait device frames? HOT 4
- Work with jpg files HOT 1
- Unable to install frameit HOT 3
- Unexpected Error & Behavior HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frameit.