Git Product home page Git Product logo

Comments (12)

DarNCelsius avatar DarNCelsius commented on May 24, 2024

This is with r318:
lxqtmutter2
I don't know why LXQt is detected as 'LXQt Desktop' here. It shows only LXQt now...

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 24, 2024

What probably happens is following:

  • Mutter detection by process fails
  • XDG_*_DESKTOP is set as WM, it falls back to process detection for DE
  • LXQT detection by process succeeds
  • DE is set to LXQT

So we have two issues here:

  1. Mutter WM detection
  2. Setting the WM to XDG_*_DESKTOP if it contains a known DE

Looking into both, any help appreciated.

from fastfetch.

DarNCelsius avatar DarNCelsius commented on May 24, 2024
╰─ echo $XDG_SESSION_DESKTOP
LXQt Desktop

╭─    ~                                                                                                                                                                                                                                                               ✔  20:17:25  
╰─ echo $XDG_CURRENT_DESKTOP
LXQt
[General]
__userfile__=true
window_manager=mutter

from fastfetch.

DarNCelsius avatar DarNCelsius commented on May 24, 2024

You're not checking for mutter in detectWMDE.c - you're checking for 'gnome-session-binary'. Might wanna extend that search if LXQt is running. Parsing session.conf seems the quickest way.
I'm not sure of the default state of that file - Openbox is the default WM for LXQt out of the box though.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 24, 2024

Yes extending the search is the right way. This will fix issue number one and additional two on setups with known WMs.

Once we fixed issue two we can check if wmPrettyName is empty in getLXQt and parse this file to get the WM if so.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 24, 2024

Pushed the fix.

from fastfetch.

DarNCelsius avatar DarNCelsius commented on May 24, 2024

That was quick 😀
lxqtmutter3

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 24, 2024

Is the WM Theme still right? Currently i simply print the GTK theme for mutter if it is not running in a Gnome session. Is this the correct behavior?

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 24, 2024

Also the output of fastfetch --terminal-font-format {} would be interesting.

from fastfetch.

DarNCelsius avatar DarNCelsius commented on May 24, 2024

Yes. The window manager handles the WM themes in LXQt.

lxqtmutter4
Seems to be the old format.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 24, 2024

Thanks i was just wondering if the font is just named Monospace (which is a bad name for a font tbh because it also is a font type) or if i am cutting something important of.

from fastfetch.

DarNCelsius avatar DarNCelsius commented on May 24, 2024

The font name is a substitution. It's really 'Deja Vu Sans Mono Book 10'
Fontconfig stuff I don't know that much about. :)

from fastfetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.