Git Product home page Git Product logo

Comments (24)

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Please post the output of fastfetch --show-errors --multithreading false

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

image

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Does fastfetch --structure Title:Separator:OS:Host:Kernel:Uptime:Packages:Resolution:DE:WM:WMTheme:Theme:Icons:Font:Cursor:Terminal:TerminalFont:CPU:GPU:Memory:Disk:Battery:Locale:Break:Colors have the same issue?

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

yes it does

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

Well it is fine when I erase "resolution" item. So it's caused because of this module I think
image

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Thanks, that makes debugging easier.

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

Of course, not a problem.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Let me sum it up so i can be sure:

  • It does work in a newly created terminal as expected
  • If a command was executed before, it has the line
  • It doesn't matter what command was executed before
  • The line always appears after the Shell output, even when multi threading is disabled
  • Removing the shell output doesn't remove the issue
  • Removing the resolution output does tho
  • Same behavior in bash and fish
  • Same behavior in different terminal emulators

If all of that is true, tbh i have no idea what even could be the problem.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Does the following command have the issue?

fastfetch --multithreading false --structure Title:Separator:OS:Host:Kernel:Uptime:Packages:Resolution:DE:WM:WMTheme:Theme:Icons:Font:Cursor:CPU:GPU:Memory:Disk:Battery:Locale:Break:Colors

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

Yes, all of that is true. Also it does that on my second device (stable PC) with same OS setup.

Does the following command have the issue?

Yes it does

Maybe I could some day try some debugging myself. I know C a little. But not sure what I can do.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

The best thing you can try is to go to src/common/detectTerminalShell.c. In line 190 you find static void getShellVersionGeneric(FFstrbuf* exe, const char* exeName, FFstrbuf* version). See if it gets executed. This is the only method that could potentially add a newline to an output. If it does, something is wrong with static void getShellVersion(FFstrbuf* exe, const char* exeName, FFstrbuf* version).

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

Ok I will look at that later. I will comment here once I try figure out something

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

I just fixed a bug in shell code, i don't believe this fixes your problem, but who knows.

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

Nope. Still same.

But found out another interesting fact. If I run fastfetch via run.sh it works properly, but if I run directly fastfetch it does not.

PS: I'm still planning to look at that code (especialy the func you recomended to me), but I haven't much time lately...

image
image

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

This is kinda expected, since calling a shell script spawns a new instance of sh, so running fastfetch through run.sh is always as if fastfetch is the first command to be entert in a terminal.

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

If you have latest version, can you please post the output of fastfetch --load-config devinfo-verbose?

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

image

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Output of fastfetch --shell-format "Before {7} After"?

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

image

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

I have problem to debug the program.
With CLion nor with gdb I'm unable to reproduce the bug in debugging enviroment. As you said earlier:

This is kinda expected, since calling a shell script spawns a new instance of sh, so running fastfetch through run.sh is always as if fastfetch is the first command to be entert in a terminal.

debugger also creates new env, where the program runs perfectly.
If you have any advice, please tell me, but currently I don't know how to debug the program.

Also I have found solution. Kind of... By accident I discovered, that clear; sleep 0.1; fastfetch works perfectly fine. I don't now how's that possible, but it is what it is. It is not clean solution, so if you have any ideas?...

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

This sounds more like a problem with clear in your terminal emulator than with fastfetch. Is it possible that bug happens with other programs too that output very fast, like clear; cat /proc/cpuinfo?

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

well no, because it does it even without clear. Cmd fastfetch will produce bug but sleep 0.1; fastfetch won't. Even without the clear cmd

from fastfetch.

LinusDierheimer avatar LinusDierheimer commented on May 27, 2024

Closing this for now, maybe it gets fixed in future by luck.

from fastfetch.

tomato4 avatar tomato4 commented on May 27, 2024

Actually it was already fixed by luck, but I forget to report it there. Thanks for the effort.

from fastfetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.