Git Product home page Git Product logo

Comments (10)

cowtowncoder avatar cowtowncoder commented on May 27, 2024

I can't say off-hand what could be causing this. Which version is this with?

from jackson-dataformats-binary.

eldadru avatar eldadru commented on May 27, 2024

Currently, 2.8.1 but also tried the latest version 2.9.0.pr2

from jackson-dataformats-binary.

cowtowncoder avatar cowtowncoder commented on May 27, 2024

@eldadru then it probably exists in 2.8.7 too. If easy enough would be nice to double-check, but if not this is fine.

from jackson-dataformats-binary.

eldadru avatar eldadru commented on May 27, 2024

Sorry, I already refactored the code

from jackson-dataformats-binary.

cowtowncoder avatar cowtowncoder commented on May 27, 2024

@eldadru that's ok, I should be able to reproduce this easily.

from jackson-dataformats-binary.

cowtowncoder avatar cowtowncoder commented on May 27, 2024

Yes, I can reproduce this. Should work, not sure yet why it does not.

from jackson-dataformats-binary.

cowtowncoder avatar cowtowncoder commented on May 27, 2024

Ok. Fixing may take a while since this is part of code I did not write (it's a contribution), and some of the logic is bit difficult to follow. Fix for short is relatively easy (it just needs to be handled like int, basically). And in theory UUID and similar types really should be handled as either String, or, perhaps, byte array (since format supports native binary content).
But for some reason current schema generator is pickier...

from jackson-dataformats-binary.

cowtowncoder avatar cowtowncoder commented on May 27, 2024

There was a bit bigger issue, but things should work significantly better after fix. Will be in 2.9.0.pr3.

from jackson-dataformats-binary.

eldadru avatar eldadru commented on May 27, 2024

@cowtowncoder Thanks!

from jackson-dataformats-binary.

cowtowncoder avatar cowtowncoder commented on May 27, 2024

@eldadru Thank you for reporting this: handling was basically wrong and could only support a small number of primitives, regular POJOs and Lists/arrays. What needed to be added was actual handling of typing as indicated by callbacks, so that (for example) date/time values are indicate as types that they would be encoded in JSON (if written as textual timestamps, then String, if long timestamps, 64-bit and so on).

I suspect there may some other rough edges but I hope these can be located and fixed over time as well.

from jackson-dataformats-binary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.