java.lang.ArrayIndexOutOfBoundsException at CBORGenerator.java:548 about jackson-dataformats-binary HOT 6 CLOSED

It looks like

if (_elementCounts.length <= _elementCountsPtr) { // less than or equal to catch more bad cases
    //use _elementCountsPtr for new size to guarantee the array is big enough for this call
    _elementCounts = Arrays.copyOf(_elementCounts, _elementCountsPtr+10);  
}
if (_elementCountsPtr > 0) { //guard for negative indexes
    _elementCounts[_elementCountsPtr++] = _currentRemainingElements;
}

doesn't work quite right. However, just adding the

if (_elementCounts.length == _elementCountsPtr) { // initially, as well as if full    
    _elementCounts = Arrays.copyOf(_elementCounts, _elementCounts.length+10);
}

guard to the methods I mentioned does the trick.

from jackson-dataformats-binary.

Thank you for reporting this.

The usual version check: is this against 2.8.7 (or 2.9.0.pr1), or some older version?

from jackson-dataformats-binary.

Running with 2.8.6. The snippets of code I copied are from the github repository though (so 2.8.7, or 2.9.0?).

from jackson-dataformats-binary.

Ok, this must be via contribution, and for 2.8. Obvious oversight, not sure how I did not catch it... especially since line 556 has proper handling (second one you suggested). I think it's ok not to check for negative indices given that code handles matching of start/end via states, although if it can become problematic it can definitely be added: these calls are not that numerous.

from jackson-dataformats-binary.

Thanks for fixing. You've been a real pro about the tickets I've submitted.

from jackson-dataformats-binary.

Thank you for submitting them! Should go without saying that these make my work much easier, when there's full info on what is going wrong. And encoding/decoding failures are critical to fix as there's usually no work around.

from jackson-dataformats-binary.